ALZ-F02 Assessment: critic code checks (ADR 0011), represents edges (ADR 0012)
Some checks failed
check agents / check (push) Failing after 12s

- Critic 0.2.0 / 0.2.1: K-04 (risk), K-05 (confidence), K-06 (TCO), K-07 (routing) and K-11
  (schema and 7R enum) run in code in the critic's hooks (app/arithmetic.py,
  app/business_logic.py); post_process sets those checks, the rejected dispositions, the
  sign-off queue and the verdict. The model keeps the judgement checks; a different reading of
  a code check is kept in unverified_claims. K-07 checks the disposition agent's own queue.
  Tests on the records of run exec_4d88027a4d26, whose model sums were wrong.
- A represents edge is not a dependency (ADR 0012): risk scorer 0.1.1 and disposition 0.1.2
  leave it out of dependents and dependencies; the disposition and critic prompts carry the
  risk scorer's rule. Run exec_1f518b04d6e4: APP-001's risk 1.00 -> 0.00, out of the tail.
- The scaffold declares the critic's hooks, copies app/ in its Dockerfile, and keeps its
  app/ and tests/ when regenerating.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-06 13:20:40 +00:00
parent bc84ee4df6
commit 041e199248
24 changed files with 1112 additions and 15 deletions

View File

@@ -33,3 +33,5 @@ Facts for this Feature's individual-agents pattern, for coding agents. Repositor
- **Never pass the scaffold an option:** `scaffold_from_stories.py --help` once took `--help` as the stories folder and deleted the six agent folders (restored from the deployed images and the scaffold). It now refuses unless every story file is there.
- **K-12 at build time (ADR 0010):** `build_workflow.py` refuses a critic deployed on an executor's model, reading each agent's `LITELLM_MODEL`; critic 0.1.4 reports K-12 from its two inputs. Run `exec_0b0afb70b8b9` (first with live Azure evidence: posture 0.69, 10 findings) failed only on K-12.
- **The critic's recalculation rules (critic 0.1.6):** the scaffold copies ALZ-ASM-03's and ALZ-ASM-04's rule sections into the critic's prompt (`RECALC_RULES`), so K-04 to K-06 recalculate with the producers' own rules. Before 0.1.6 the critic had none (run `exec_1779863642d6`, K-04).
- **Critic 0.2.0 (ADR 0011):** K-04 to K-07, K-11 and the verdict are set in code by the critic's hooks; the scaffold keeps its `app/` and `tests/` when regenerating. Run `exec_4d88027a4d26` failed on the model's own sums (0.70 for 1.00; 0.60 for 0.50).
- **Run `exec_2cd7a953335b` (critic 0.2.0):** code checks ran; K-04 to K-06 passed. Two faults fixed: K-07 compared the wrong queue (critic 0.2.1), and the dependents rule counted `represents` edges (ADR 0012; risk 0.1.1, disposition 0.1.2).