ALZ-F01 Discovery: package step, value scorecard, application grouping, cases

- New cp1-discovery-package-agent (ADR 0020): one package per reviewed run, every part
  hashed (sha256 over canonical JSON), with a manifest and a value scorecard.
- Applications grouped CMDB -> tag -> resource group with a judged model fallback (ADR 0021):
  CMDB 0.7.0 carries ownership, dependency mapping 0.6.0 groups, report 0.9.0 shows them.
- Critic 0.6.1 accepts the producers' enums; build_workflow.py refuses a consumer enum
  narrower than its producer's.
- Code hooks, sub-agents and tests for the inventory, CMDB, dependency, planner and critic
  agents; the report and Well-Architected review agents; ADRs 0012-0021.
- Workflow cases with value bars and run limits; run evaluation and usage collection scripts;
  the run context template and the field-by-field review for ADR 0016.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-05 22:13:25 +00:00
parent f659564208
commit 9e503885cc
211 changed files with 18170 additions and 158 deletions

View File

@@ -4,9 +4,10 @@ Facts for this Feature's individual-agents pattern, for coding agents. Repositor
## Pattern
- **Eight declarative agents, one per ALZ-DSC story.** Each declares its own read-only MCP tools under `mcp:` (allowed for top-level agents; only sub-agents can't hold MCP tools).
- **Eleven agents:** one per ALZ-DSC story, plus the report, the Well-Architected review and the package. Each declares its own read-only MCP tools under `mcp:` (allowed for top-level agents; only sub-agents can't hold MCP tools). The package agent declares none.
- **The workflow (`workflows/cp1-alz-discovery-individual.json`) is the orchestration:** step order through `parallelGroup` and `executionLevel`, and data through `from_steps` (`"<input>": "sN.<output field>"`). The step map is `STEPS` in `scripts/build_workflow.py`.
- **Nothing persists between steps** except their replies (ADR 0010). There's no workspace, no hooks and no enforced verdict; the critic is gated by a human approval (ADR 0006).
- **Nothing persists between steps** except their replies (ADR 0010). There's no workspace. Hooks answer the steps their ADRs name. The review point is on the report step (ADR 0012); the pages and the package (`s13`, ADR 0020) run only after it.
- **The package is Discovery's hand-over to the Assessment workflow (F02), its only consumer.** The solution architecture agent (`outcome-pattern/`) is a separate stream: build no hand-over to it.
## Sources of truth
@@ -22,4 +23,5 @@ Facts for this Feature's individual-agents pattern, for coding agents. Repositor
- **Runtime:** `cruciblecoredevacr.azurecr.io/kab/agent-runtime-adk:0.35.7`. Images are pushed to `cruciblecoredevacr.azurecr.io/kab/cp1/<agent>:<version>`.
- **Cluster:** `crucible-kab-dev-aks`, namespace `agents`, kubeconfig `/mnt/c/Users/JonathanBoniface/.kube/config`. The gateways are in `core-components`: LiteLLM on `:4000`, the MCP gateway on `:8000`. There's no `agent-platform-connections` ConfigMap, so the deploy profile sets the gateway URLs.
- **An agent needs its own `MCP_AGENT_API_KEY`** (Secret `<agent>-secrets`), issued when it's created in KAB. Without it, every request fails at startup.
- **As of 2026-10-29, MCP server registration fails** in the MCP gateway, because KAB's default tenant `6ada663eb5b88053a9e43723` isn't mapped there (it fails row-level security). This blocks every agent in both patterns.
- **The `agents` namespace allows 30 Deployments** (ResourceQuota `kab-eng-agents`) and is full. On 2026-11-05, to deploy Assessment, `cp4-spike-echo-agent` and the sub-agent pattern's `cp1-alz-discovery-orchestrator-agent` were deleted at the owner's choice; their manifests are in the engineering hub's `reports/cp1/deleted-deployment-*-2026-11-05.yaml`. A new agent needs a free slot.
- **MCP servers and agent keys belong to the CP1 tenant** (`6ae37d13999438461a529409`). Registration still fails in KAB's default tenant, which these agents don't use.