ALZ-F01 Discovery: package step, value scorecard, application grouping, cases

- New cp1-discovery-package-agent (ADR 0020): one package per reviewed run, every part
  hashed (sha256 over canonical JSON), with a manifest and a value scorecard.
- Applications grouped CMDB -> tag -> resource group with a judged model fallback (ADR 0021):
  CMDB 0.7.0 carries ownership, dependency mapping 0.6.0 groups, report 0.9.0 shows them.
- Critic 0.6.1 accepts the producers' enums; build_workflow.py refuses a consumer enum
  narrower than its producer's.
- Code hooks, sub-agents and tests for the inventory, CMDB, dependency, planner and critic
  agents; the report and Well-Architected review agents; ADRs 0012-0021.
- Workflow cases with value bars and run limits; run evaluation and usage collection scripts;
  the run context template and the field-by-field review for ADR 0016.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-05 22:13:25 +00:00
parent f659564208
commit 9e503885cc
211 changed files with 18170 additions and 158 deletions

View File

@@ -1,3 +1,39 @@
## [0.3.2] - 2026-11-03
### Fixed
- Prompt placeholders are written `<provider>`, not `{provider}`: the runtime reads `{name}` in a prompt as a session variable, and 0.3.1 failed with "Context variable not found: `provider`".
## [0.3.1] - 2026-11-03
### Fixed
- `mcp:` names the cloud servers by the gateway's display names, "Azure Discovery" and "Google Cloud Discovery". With the server ids, 0.3.0 failed at startup: the gateway offers servers by display name.
## [0.3.0] - 2026-11-03
### Added
- The `provider` input: `sample` (unchanged) or a live cloud, `azure` or `gcp`, read through the existing discovery servers (ADR 0013). Live tools: `{provider}_list_data_stores`.
## [0.2.2] - 2026-11-02
### Changed
- Accepts a `reason` on each source gap: `not_requested` or `no_connection`.
## [0.2.1] - 2026-11-01
### Fixed
- `store_name` is the schema's own name whenever a schema exists.
## [0.2.0] - 2026-11-01
### Fixed
- A store with no schema is reported as `unclassified`. It was left out without saying so.
## [0.1.0] - 2026-10-29
### Added

View File

@@ -1,7 +1,7 @@
name: "cp1-data-classification-agent"
display_name: "CP1 - Data Classification Agent"
description: "Classifies data stores PII / PCI / PHI / none from schema metadata only, and marks the stores that need data-disposition controls."
version: "0.1.0"
version: "0.3.2"
framework: "adk"
tags:
- "cp1"
@@ -17,6 +17,10 @@ contract:
mcp:
alz-schema:
- "scan_schema"
"Azure Discovery":
- "azure_list_data_stores"
"Google Cloud Discovery":
- "gcp_list_data_stores"
skills:
- id: "cp1_data_classification_agent"
name: "CP1 - Data Classification Agent"

View File

@@ -1,11 +1,13 @@
# Changes to ALZ-DSC-05's original requirements
The decisions are recorded once, for all eight agents, in the Feature's [docs/adr/](../../../docs/adr/README.md). These change what the ALZ-DSC-05 story (ADO 3214455) and its v1.1 story files say:
The decisions are recorded once, for all agents, in the Feature's [docs/adr/](../../../docs/adr/README.md). These change what the ALZ-DSC-05 story (ADO 3214455) and its v1.1 story files say:
- [ADR 0001](../../../docs/adr/0001.md)
- [ADR 0002](../../../docs/adr/0002.md)
- [ADR 0003](../../../docs/adr/0003.md)
- [ADR 0007](../../../docs/adr/0007.md)
- [ADR 0008](../../../docs/adr/0008.md)
- [ADR 0010](../../../docs/adr/0010.md)
- [ADR 0013](../../../docs/adr/0013.md)
A change that affects only this agent gets its own record here, numbered `05-NNNN`.

View File

@@ -44,7 +44,7 @@ data:
# model, so setting those is silently ignored — the agent keeps running at the
# defaults with no error to chase.
LITELLM_TEMPERATURE: "1"
LITELLM_MAX_TOKENS: "32000"
LITELLM_MAX_TOKENS: "80000"
# =============================================================================
# Agent Loop Guard Rails

View File

@@ -1,7 +1,7 @@
# CP1 - Data Classification Agent
ALZ-DSC-05 (ADO 3214455), a step of the workflow "CP1 - Agentic Landing Zone - Discovery". The workflow
gives you your inputs (`engagement_id`, `run_id`, `records`) from earlier steps, and passes your reply to later ones. Reply with only the JSON
gives you your inputs (`engagement_id`, `run_id`, `records`, `source_gaps`) from earlier steps, and passes your reply to later ones. Reply with only the JSON
object your output schema defines: no prose, no markdown fence.
## MCP tools
@@ -9,10 +9,49 @@ object your output schema defines: no prose, no markdown fence.
| Server | Tool | Access |
|---|---|---|
| `alz-schema` | `scan_schema` | read |
| `azure-discovery` | `azure_list_data_stores` | read |
| `gcp-discovery` | `gcp_list_data_stores` | read |
**Steps:**
1. For each record in `records` whose `asset_class` is `database` or `storage_array`, call `alz-schema.scan_schema(scope_entry_id)`. It returns metadata, never rows.
2. If `source_gaps` lists `schema`, or a store has no schema, still emit its store: `store_name` is the hostname, `highest_class` is `'unclassified'`, zero counts, `requires_disposition_controls` false, no `column_tags`, and `reason` says no schema was available. Never leave a store out.
## Live provider
`provider` is set once for the whole run. `sample` means the Meridian sample estate through the `alz-*` tools:
everything in this prompt applies as written and you ignore this section. `azure` or `gcp` means a live cloud,
read through that cloud's discovery server, and these rules replace the `alz-*` steps above:
- **One cloud only.** Use only the tools whose names start with `<provider>_`. Never call another cloud's tools or
the `alz-*` tools: a call to another cloud's tool reads a different estate and is a critical defect.
- **Identifiers.** A scope entry is a cloud resource, and its `scope_entry_id` is the resource's own name (`gcp`,
e.g. `//compute.googleapis.com/projects/p/zones/z/instances/i`) or id (`azure`, e.g.
`/subscriptions/s/resourceGroups/g/providers/...`) exactly as a tool returned it. It is an identifier, not a URL:
passing one an earlier call in this run returned is allowed. Never pass anything else.
- **Missing sources.** A live run has no CMDB, ITSM, flow or schema source. They are declared gaps, never filled
in, and never reported as clean results.
- **Volume.** Never call `<provider>_list_recommendations`, `<provider>_query_resources`, or
`<provider>_list_resources` without a type: their output is too large for a step.
**Kinds:**
| Tool | `azure` kinds | `gcp` kinds |
|---|---|---|
| `list_accounts` | `subscriptions`, `resource_groups` | `projects` |
| `list_servers` | `virtual_machines`, `scale_sets` | `instances` |
| `list_workloads` | `app_service`, `container_apps`, `container_instances` | `cloud_run`, `cloud_functions`, `app_engine` |
| `list_kubernetes_clusters` | (takes no kind) | `clusters` |
| `list_data_stores` | `sql`, `cosmos_db`, `storage_accounts`, `postgresql`, `mysql`, `redis` | `cloud_sql`, `firestore`, `cloud_storage` |
| `get_network_topology` | `virtual_networks`, `route_tables`, `network_security_groups`, `gateways`, `load_balancers`, `private_endpoints`, `public_ips` | `networks`, `subnetworks`, `routes`, `firewall_rules`, `load_balancers`, `gateways` |
Call a tool once for **every** kind its row lists, with `page_size` 50, and follow `next_page_token` to the end. A
tool called without `kind` returns its first kind only.
**Classifying a live run:** call `<provider>_list_data_stores` for every kind in **Kinds**. For each data store
that is a scope entry in `records`: `store_name` its name; `highest_class` `unclassified`; every class count 0;
`column_tags` empty; `reason` "Metadata only: no schema source in this run". Set `requires_disposition_controls`
true only when a label or tag marks the store as holding personal or card data, and say so in `reason`.
## Role: Data Classification Executor (workflow: discovery, safety class 1 read-only)
@@ -40,8 +79,8 @@ Use these **EXACT** specifications:
- **Store Classification Schema**:
- `canonical_id`: STRING
- `store_name`: STRING
- `highest_class`: ENUM (`'PCI'`, `'PHI'`, `'PII'`, `'none'`)
- `store_name`: STRING (the `store_name` `scan_schema` returns; the hostname only when there is no schema)
- `highest_class`: ENUM (`'PCI'`, `'PHI'`, `'PII'`, `'none'`, `'unclassified'`)
- `class_counts`: `{ PII: INTEGER, PCI: INTEGER, PHI: INTEGER, review_required: INTEGER }`
- `requires_disposition_controls`: BOOLEAN
- `reason`: STRING

View File

@@ -175,6 +175,48 @@
"confidence"
]
}
},
"source_gaps": {
"type": "array",
"default": [],
"items": {
"type": "object",
"properties": {
"source": {
"type": "string",
"enum": [
"cmdb",
"itsm",
"netflow",
"schema"
]
},
"impact": {
"type": "string"
},
"reason": {
"type": "string",
"enum": [
"not_requested",
"no_connection"
]
}
},
"required": [
"source",
"impact"
]
}
},
"provider": {
"type": "string",
"enum": [
"sample",
"azure",
"gcp"
],
"default": "sample",
"description": "Which estate this run reads: `sample` (the Meridian sample estate, through the alz-* tools) or a live cloud, `azure` or `gcp`, through that cloud's discovery server. Set once for the whole workflow run."
}
},
"required": [

View File

@@ -18,7 +18,8 @@
"PCI",
"PHI",
"PII",
"none"
"none",
"unclassified"
]
},
"class_counts": {