ALZ-F02 Assessment: individual agents, intake, rate card input, critic fixes

- Six declarative agents generated from the v1.1 stories (scaffold_from_stories.py, ADR 0001),
  and a 9-step workflow export (build_workflow.py).
- Code-only intake (ADR 0008) verifies the one Discovery package in code before any agent.
- The rate card is the run input rate_card_document; no upload step (ADR 0009).
- Critic 0.1.6 after live runs on crucible-kab-dev:
  - K-12 model independence checked at build time against each agent's deployed model
    (ADR 0010); the critic reports it from its two inputs;
  - receives in_cloud_estate for K-10; an unverified K-10 never fails the run alone;
  - K-08 allows the scoring note to list findings as advisory, as ALZ-ASM-04 must;
  - carries ALZ-ASM-03's and ALZ-ASM-04's rule sections, copied by the scaffold, so it can
    recalculate risk, confidence and TCO.
- The scaffold refuses to regenerate unless every story file is present.
- Case azure-crucible-kab-dev-assessment with an illustrative rate card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-05 22:13:25 +00:00
parent 9e503885cc
commit e22d037ab0
153 changed files with 13004 additions and 0 deletions

View File

@@ -0,0 +1,45 @@
# 0008. Assessment reads one Discovery package, checked in code by an intake step before any agent
| | |
|---|---|
| Status | Accepted |
| Date | 2026-11-05 |
| Decided by | Product owner, 2026-11-05: "lets move forward with each of these", on the plan step "F02 verifies the package's manifest in code (F02's own ADR), and selects one artifact" (F01 `docs/discovery-value-plan.md`, phase 1; F01 ADR 0020) |
| Requirements changed | ALZ-ASM-01 US-001 (preconditions): "Discovery completed" and "critic verdict pass" are checked in code from the package's manifest before the planner runs. ADR 0002: one artifact, the package, replaces one artifact per Discovery step. ADR 0001: one code-only step, outside the six generated agents |
## Context
- Discovery now writes one package per reviewed run (F01 ADR 0020): every step's output as a named part, with a
manifest holding a `sha256` per part, `complete`, the critic's verdict and the Discovery execution id.
- Until now, the person starting Assessment typed in one artifact id per Discovery step, and the planner, a model,
judged from the text whether Discovery had completed and passed (ADR 0002). Nothing checked that the documents were
unchanged, complete, or from the run named.
- The six Assessment agents are declarative and generated from the story files (ADR 0001); a hook added to one would
be lost when they're regenerated.
## Decision
1. **A code-only intake step, `s0`, `cp1-assessment-intake-agent`,** runs after the parse step and before the
planner. It isn't generated from the stories, and it has no model and no tools.
2. **It checks, in code** (`app/intake.py`): exactly one package among the selected artifacts, wherever KAB's wrapping
puts it; a package version it reads (`1.0`); every part the manifest lists is present and matches its `sha256`;
`complete`; the critic's verdict `pass`; the manifest's execution id equals the run's `discovery_execution_id`, and
its engagement equals `engagement_id`.
3. **It fails closed.** Any failed check raises, so the step fails with the reasons and no Assessment agent runs.
4. **The planner waits for it** (`s1` depends on `s0`). On success it returns `verified`, the parts it checked, the
source gaps, the agent versions, Discovery's applications (F01 ADR 0021) and the scorecard.
5. **The person starting a run selects one artifact:** the Discovery run's package step output.
## Consequences
- **"Discovery completed" and "critic passed" are facts checked in code,** not the planner's reading of the text.
The planner still sees the documents and still writes its preconditions; it can't start on a package the intake
refused.
- **The approval is still implied, not explicit.** The package exists only for a run continued past Discovery's
review point, but the decision record itself isn't visible to Assessment (ADR 0002's open platform question).
- **A run selecting the old per-step artifacts is refused,** because they hold no package. Assessment hasn't been
deployed, so nothing in use breaks.
- **The six agents' inputs are unchanged.** They still read `discovery_documents`, now one package rather than ten
documents. Giving them typed fields from the intake (and shrinking each prompt) is a later step.
- **Tested** on the live package of Discovery run `exec_14956d524a8b`, and on changed, removed, failed, foreign,
duplicate, missing and newer-version packages.