# 0014. One Assessment package after sign-off, with a register, a gaps register and the sign-off record, built in code | | | |---|---| | Status | Accepted | | Date | 2026-11-08 | | Decided by | Product owner, 2026-11-08: "yes lets go with the receommations", on [../assessment-outputs-proposal.md](../assessment-outputs-proposal.md) (decisions 1, 2, 4 and 6). Decision 5 had no recommendation: the new agent is recorded here, not on the board, until the product owner says otherwise | | Requirements changed | ALZ-F02 Outputs ("Assessment deliverable"): now the Assessment package. ALZ-ASM-06's `disposition_signoff` is no longer the last step. New step `s8` (first built as `s7`; moved behind the report by ADR 0015), agent `cp1-assessment-package-agent` (no story) | ## Context - The Feature promises an "Assessment deliverable", but the workflow ended at the critic's review point. It left seven step artifacts, each in its own shape, and a review decision held only in KAB's activity log. - Strategy (F03) needs "signed-off dispositions and risk scores"; the Business Case (F04) the TCO models; Target Architecture (F05) and Wave Planning (F06) the signed-off dispositions. Each would have had to find and join seven artifacts, the problem Discovery's package solved for Assessment (F01 ADR 0020). - What Assessment had to do without was never stated in one place. In run `exec_49e355141382`, APP-001's risk score is partial, and its confidence lost 0.40 to missing telemetry, unknown support status and the partial score. ## Decision 1. **A package step, `s8`, answered in code** (`cp1-assessment-package-agent`, `app/package.py`, no model, no tools): - It depends on every agent step, so it runs only after the run is continued at `disposition_signoff` (on the report step since ADR 0015, which also gives the package a `report` part). - Every step's output fields are **copied unchanged** into parts named by meaning: `discovery` (the intake's verification), `plan`, `profiles`, `risk`, `security`, `dispositions`, `critic`. - Its `manifest` holds the lineage (the Discovery run, its package's artifact id and the intake's verification; the rate card's id and sha256, not its content; the models; each agent's version), the sign-off record, a `sha256` and item count per part, `complete`, `problems` and a scorecard. - Each `sha256` is over canonical JSON, computed exactly as Discovery's package step does, so F03 can verify the package the way the intake verifies Discovery's (ADR 0008). - `complete` only when every copied part is present, the critic passed and the intake verified the Discovery package. 2. **Two parts are worked out in code, never by a model:** - `register`: one row per planned application, joining disposition, confidence, matched rule, sign-off, risk, dependents, readiness, cost, advisory findings and the primary evidence. It is what the later Features read. - `gaps`: per application, each thing Assessment had to do without (a missing risk factor, an unknown readiness signal, a confidence deduction, a missing TCO input, a coverage or profile gap), its effect, the producer's basis, and the Discovery source or field that would fill it. Discovery's source gaps are carried through. 3. **Sign-off: continuing at `disposition_signoff` signs off the queue as it stands.** Each register row's `signoff` is `signed_off` (in the critic's queue), `not_required`, `rejected`, `not_disposed`, or `not_signed_off` when the verdict isn't `pass` (a fail verdict is never approved). The next workflow records the approval as its run input `assessment_approval_ref`, as Assessment takes `discovery_approval_ref` (ADR 0002). Overriding single dispositions is left for later. ## Consequences - **The later Features select one artifact,** the package step's (`_step_`, as KAB names it), and can check every part before trusting it. - **The Assessment report** (proposal decision 3) is ADR 0015. - **The reviewer's identity and time are not in the package:** KAB keeps them in the activity log (`kab_run_workflow.py status` shows `decided_by`). The next workflow's `assessment_approval_ref` carries them. - **A run continued with a fail verdict** still gets a package, marked incomplete and signed off for nothing.