Files
cp1-agents/individual-agents/ALZ-F02: Assessment & Disposition Workflow Agent/docs/adr/0012.md
Jonathan Boniface 041e199248
Some checks failed
check agents / check (push) Failing after 12s
ALZ-F02 Assessment: critic code checks (ADR 0011), represents edges (ADR 0012)
- Critic 0.2.0 / 0.2.1: K-04 (risk), K-05 (confidence), K-06 (TCO), K-07 (routing) and K-11
  (schema and 7R enum) run in code in the critic's hooks (app/arithmetic.py,
  app/business_logic.py); post_process sets those checks, the rejected dispositions, the
  sign-off queue and the verdict. The model keeps the judgement checks; a different reading of
  a code check is kept in unverified_claims. K-07 checks the disposition agent's own queue.
  Tests on the records of run exec_4d88027a4d26, whose model sums were wrong.
- A represents edge is not a dependency (ADR 0012): risk scorer 0.1.1 and disposition 0.1.2
  leave it out of dependents and dependencies; the disposition and critic prompts carry the
  risk scorer's rule. Run exec_1f518b04d6e4: APP-001's risk 1.00 -> 0.00, out of the tail.
- The scaffold declares the critic's hooks, copies app/ in its Dockerfile, and keeps its
  app/ and tests/ when regenerating.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 13:20:40 +00:00

2.0 KiB

0012. A represents edge is not a dependency

Status Accepted
Date 2026-11-05
Decided by Product owner, 2026-11-05: "lets solve these first" (the run's faults are fixed before it is repeated); the rule follows Discovery's F01 ADR 0019
Requirements changed ALZ-ASM-03 and ALZ-ASM-04: the Application Dependents rule leaves out represents edges. ALZ-ASM-04 and ALZ-ASM-06 use ALZ-ASM-03's rule

Context

  • The Application Dependents rule (ALZ-ASM-03) lifts every ALZ-DSC-06 edge to applications.
  • Since F01 ADR 0019, Discovery also writes a represents edge for each CMDB record it matched to an inventory asset (CMDB CI → resource). It records that the two are the same asset; it isn't a dependency.
  • In run exec_2cd7a953335b, the eight represents edges of APP-001 (E-008 to E-015) were counted as eight dependents:
    • the risk scorer set fan-in to 1.0, the only factor available, so the score was 1.00 and APP-001 was high-risk;
    • the disposition agent ruled out retire for eight dependents. The critic model rejected the disposition under K-02 for citing them. Its other edges (E-001, E-002, E-005, E-007) run from APP-001's own assets outwards: they are dependencies, not dependents.
  • ALZ-ASM-04's prompt had no rule of its own for lifting dependents.

Decision

  1. dependency(e) = e.type != 'represents' in ALZ-ASM-03's Application Dependents rule: a represents edge is left out of both an application's dependents and its dependencies.
  2. ALZ-ASM-04 and ALZ-ASM-06 carry ALZ-ASM-03's rule, copied into their prompts by the scaffold, so all three lift dependents the same way.

Consequences

  • APP-001 has no dependents in the current Discovery package: fan-in 0.0, so its risk score falls from 1.00 to 0.00 on the one factor available, and it leaves the high-risk tail. Retire is still ruled out by its assets' retire_constraint.
  • A future Discovery edge type that isn't a dependency needs the same treatment here.