Files
Jonathan Boniface 9e503885cc ALZ-F01 Discovery: package step, value scorecard, application grouping, cases
- New cp1-discovery-package-agent (ADR 0020): one package per reviewed run, every part
  hashed (sha256 over canonical JSON), with a manifest and a value scorecard.
- Applications grouped CMDB -> tag -> resource group with a judged model fallback (ADR 0021):
  CMDB 0.7.0 carries ownership, dependency mapping 0.6.0 groups, report 0.9.0 shows them.
- Critic 0.6.1 accepts the producers' enums; build_workflow.py refuses a consumer enum
  narrower than its producer's.
- Code hooks, sub-agents and tests for the inventory, CMDB, dependency, planner and critic
  agents; the report and Well-Architected review agents; ADRs 0012-0021.
- Workflow cases with value bars and run limits; run evaluation and usage collection scripts;
  the run context template and the field-by-field review for ADR 0016.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:13:25 +00:00

1.5 KiB

Context: CP1 - Discovery Critic Agent

For coding agents. People's documentation is in docs/.

Story ALZ-DSC-08 (ADO 3214458); v1.1 story file drafts/cp1/agentic-landing-zone/stories/F01-discovery/ALZ-DSC-08-* in the engineering hub workspace
Workflow step 8 of ../workflows/cp1-alz-discovery-individual.json
Inputs from earlier steps coverage_gaps <- s1.coverage_gaps, findings <- s2.findings, records <- s3.records, drift_items <- s4.drift_items, stores <- s5.stores, network_findings <- s6.findings, edges <- s7.edges
MCP tools (read-only) alz-scope.get_scope, alz-evidence.get_call_log, alz-evidence.get_guard_hits
Model gpt-5.6-sol (kubernetes/configmap.yaml), shared with the executors: see ADR 0008

How the prompt was made

prompt.md is the story's v1.1 System Prompt and Guardrails, plus three generated sections at the top (MCP tools, steps, inputs) and the charter at the end. The alz-run hand-off tools and the MCP write tools are rewritten out (repository ADRs 0002 and 0003). The rules stay as the story's pseudo-code. A declarative agent has no functions, so the model applies them itself; the eval cases check the ones that matter.

Invariants

  1. The reply is exactly schemas/output.json. Later steps read its fields by name.
  2. Every MCP tool in agent.yaml mcp: is read-only, and is listed in the story's allowlist.
  3. No orchestrator: this agent is called once per run by the workflow, and its only memory is its inputs.