Files
cp1-agents/individual-agents/ALZ-F02: Assessment & Disposition Workflow Agent/docs/adr/0014.md
Jonathan Boniface 66c32745aa
Some checks failed
check agents / check (push) Failing after 14s
F02: Assessment report and package (ADR 0014, 0015); register agents in KAB
- Report (cp1-assessment-report-agent 0.2.0, step s7): a model writes the
  Assessment report from facts worked out in code (register, gaps, scorecard,
  rule traces, checks, and what each application is from the Discovery
  package); code sets the verdict and renders the pages. The
  disposition_signoff review point moves from the critic to the report.
- Package (cp1-assessment-package-agent 0.1.1, step s8): after sign-off, every
  step's output in one package, with a register, a gaps register, the
  sign-off record, lineage and a sha256 per part, in code. Page step s9.
- scripts/kab_register_agents.py: registers deployed agents in KAB's agent
  catalog (an in-place workflow update doesn't).
- Runs exec_1b1257380df7 (014) and exec_374d5d577077 (015) completed on
  crucible-kab-dev: critic pass, report figures all in its facts, package
  complete with every digest recomputing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 20:19:10 +00:00

4.2 KiB

0014. One Assessment package after sign-off, with a register, a gaps register and the sign-off record, built in code

Status Accepted
Date 2026-11-08
Decided by Product owner, 2026-11-08: "yes lets go with the receommations", on ../assessment-outputs-proposal.md (decisions 1, 2, 4 and 6). Decision 5 had no recommendation: the new agent is recorded here, not on the board, until the product owner says otherwise
Requirements changed ALZ-F02 Outputs ("Assessment deliverable"): now the Assessment package. ALZ-ASM-06's disposition_signoff is no longer the last step. New step s8 (first built as s7; moved behind the report by ADR 0015), agent cp1-assessment-package-agent (no story)

Context

  • The Feature promises an "Assessment deliverable", but the workflow ended at the critic's review point. It left seven step artifacts, each in its own shape, and a review decision held only in KAB's activity log.
  • Strategy (F03) needs "signed-off dispositions and risk scores"; the Business Case (F04) the TCO models; Target Architecture (F05) and Wave Planning (F06) the signed-off dispositions. Each would have had to find and join seven artifacts, the problem Discovery's package solved for Assessment (F01 ADR 0020).
  • What Assessment had to do without was never stated in one place. In run exec_49e355141382, APP-001's risk score is partial, and its confidence lost 0.40 to missing telemetry, unknown support status and the partial score.

Decision

  1. A package step, s8, answered in code (cp1-assessment-package-agent, app/package.py, no model, no tools):
    • It depends on every agent step, so it runs only after the run is continued at disposition_signoff (on the report step since ADR 0015, which also gives the package a report part).
    • Every step's output fields are copied unchanged into parts named by meaning: discovery (the intake's verification), plan, profiles, risk, security, dispositions, critic.
    • Its manifest holds the lineage (the Discovery run, its package's artifact id and the intake's verification; the rate card's id and sha256, not its content; the models; each agent's version), the sign-off record, a sha256 and item count per part, complete, problems and a scorecard.
    • Each sha256 is over canonical JSON, computed exactly as Discovery's package step does, so F03 can verify the package the way the intake verifies Discovery's (ADR 0008).
    • complete only when every copied part is present, the critic passed and the intake verified the Discovery package.
  2. Two parts are worked out in code, never by a model:
    • register: one row per planned application, joining disposition, confidence, matched rule, sign-off, risk, dependents, readiness, cost, advisory findings and the primary evidence. It is what the later Features read.
    • gaps: per application, each thing Assessment had to do without (a missing risk factor, an unknown readiness signal, a confidence deduction, a missing TCO input, a coverage or profile gap), its effect, the producer's basis, and the Discovery source or field that would fill it. Discovery's source gaps are carried through.
  3. Sign-off: continuing at disposition_signoff signs off the queue as it stands. Each register row's signoff is signed_off (in the critic's queue), not_required, rejected, not_disposed, or not_signed_off when the verdict isn't pass (a fail verdict is never approved). The next workflow records the approval as its run input assessment_approval_ref, as Assessment takes discovery_approval_ref (ADR 0002). Overriding single dispositions is left for later.

Consequences

  • The later Features select one artifact, the package step's (<exec>_step_<N>, as KAB names it), and can check every part before trusting it.
  • The Assessment report (proposal decision 3) is ADR 0015.
  • The reviewer's identity and time are not in the package: KAB keeps them in the activity log (kab_run_workflow.py status shows decided_by). The next workflow's assessment_approval_ref carries them.
  • A run continued with a fail verdict still gets a package, marked incomplete and signed off for nothing.