diff --git a/.scratch/solution-architect-agent/spec.md b/.scratch/solution-architect-agent/spec.md index 4f94c21..4db0053 100644 --- a/.scratch/solution-architect-agent/spec.md +++ b/.scratch/solution-architect-agent/spec.md @@ -468,3 +468,39 @@ These are ordered, and each leaves the suite green. They are called *increments* - **Uneven hosting across Cloud providers.** AWS hosts a managed MCP server. Azure's general MCP server is self-hosted. The bundle's `url` covers both, but "hosted by the Cloud provider" isn't uniform. ## Comments + +### 2026-09-15 · Increment 1: environment and baseline + +**Environment** +- Branch `feat/solution-architect-agent` (already created and pushed, commit `4fefe0a`). +- `.venv/` (gitignored), Python 3.12.3. Installed `requirements.txt` and `requirements-dev.txt` with no errors. +- Resolved versions: + - `google-adk` 2.9.0 (the spec's floor is `>=1.25`; `google.adk.skills` and `SkillToolset` import fine, and the toolset also exposes `ListSkillsTool`, `SearchSkillsTool`, `SkillRegistry` and `RunSkillScriptTool`) + - `langgraph` 1.2.11, `langgraph-checkpoint` 4.2.0 + - `langchain-core` 1.6.3 + - `starlette` 1.6.0 + - `pytest` 9.1.1, `pytest-asyncio` 1.4.0 +- CLIs already on the machine: `terraform` 1.14.3 (`/usr/bin/terraform`), `gcloud`, `psql`. +- The real `google-adk` is now installed, but `app.adk.compat.HAS_NATIVE_ADK` is still `False`, because compat also imports `google.adk.workflows` and `google.adk.evaluation`, which fail. The stubs stay in use, so baseline behaviour is unchanged. +- No local PostgreSQL is running, so every `DatabaseManager` call logs a connection-refused warning and falls back to `gcp_agent_local.db`. + +**Baseline** +- Command: `.venv/bin/python -m pytest tests eval/test_eval_harness.py -rA`. +- Result: **30 passed, 0 failed, 1 warning, ~37 s**. The warning is a Starlette `TestClient` deprecation (`anyio.abc.BlockingPortal`). + +| File | Passed | +|---|---| +| `tests/test_adk_architecture.py` | 8/8 | +| `tests/test_agent_api.py` | 4/4 | +| `tests/test_artifacts.py` | 5/5 | +| `tests/test_graph_workflow.py` | 1/1 | +| `tests/test_mcp_developer_knowledge.py` | 5/5 | +| `tests/test_package.py` | 2/2 | +| `tests/test_skill_loader.py` | 3/3 | +| `eval/test_eval_harness.py` | 2/2 | + +Slowest tests: eval benchmark 7.3 s, then 3–4.5 s each for the orchestrator, evaluator, workflow, graph, session API and runner tests. + +**Side effects found (fix in increment 9 or earlier if they get in the way)** +- **New Execution folders.** Each suite run creates 6 new untracked `deliverables/executions//` directories. The shared-path copies are byte-identical because the templates don't vary. I removed the 12 from two runs with `git clean -fd deliverables/executions/`. +- **Tracked bytecode.** 30 `__pycache__/*.pyc` files are tracked despite `.gitignore`, so every run dirties the tree (for example `eval/__pycache__/*.pyc`). Candidate fix: `git rm -r --cached '*/__pycache__'`.