feat: keep an unchanged description, list conditions, review coverage with Jev

After case 02 (completed at 100%, but with two Revisions of the Target
architecture for gaps validation found one pass at a time):

- A Deliverable stands while what it was written from is unchanged. The
  architecture description is written from the Elements and Relationships,
  so a Revision that only adds or rewords Checks no longer runs the describer.
- Non-functional requirements and recommendations list their conditions,
  one entry per separate thing that must be true; submission requires them.
- A coverage review at submission (JEV_COVERAGE_REVIEW, off by default):
  for each condition, Jev chooses which Check verifies it, or none. Asked as
  one broad yes-or-no per requirement it could not tell a complete design
  from one with known gaps; asked as a choice per condition it raised all
  four known gaps of case 02 and nothing on the complete graph. An opt-in
  live test (LIVE_JEV=1) repeats that.
- The validator is told to report every gap in its first pass.

Plans record the case 02 run and both forms of the review with figures.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-07 20:58:38 +01:00
parent f1f6f1b83a
commit 5adc911a82
29 changed files with 1687 additions and 16 deletions

View File

@@ -29,6 +29,7 @@ from app.adk.runtime import (
NoDecider,
RoleSpec,
RunLimiter,
SubmissionReview,
ToolFactory,
)
from app.checkpointing import open_checkpointer
@@ -46,6 +47,7 @@ from app.recorder import DatabaseRecorder, ExecutionRecorder
from app.skills.agent_skills import skill_version
from app.states.execution_state import check_customer_case
from app.states.ledger import Ledger
from app.tools.coverage import CoverageReview
from app.tools.execution import ORCHESTRATOR
from app.tools.jev import JevDecider, JevLimits
from app.tools.local import TerraformRunner, local_tools
@@ -84,6 +86,7 @@ class ExecutionEngine:
limiter: RunLimiter | None = None,
skill_versions: Mapping[str, str] | None = None,
orchestrator: OrchestratorPolicy | None = None,
submission_review: SubmissionReview | None = None,
) -> None:
required = {
ORCHESTRATOR,
@@ -104,6 +107,7 @@ class ExecutionEngine:
limiter=limiter,
skill_versions=skill_versions,
orchestrator=orchestrator,
submission_review=submission_review,
).compile(checkpointer=checkpointer)
async def start(
@@ -334,6 +338,13 @@ async def open_assembly(
name: skill_version(meta.path) for name, meta in bundle.skills.items()
},
orchestrator=orchestrator,
# Optional, and off by default: Jev reviews a design's coverage before
# it is submitted. Without it a submission stands on its structure.
submission_review=CoverageReview(
decider, none_at=settings.JEV_COVERAGE_THRESHOLD
)
if settings.JEV_COVERAGE_REVIEW and isinstance(decider, JevDecider)
else None,
)
try:
yield Assembly(engine, bundle, roles, dict(catalog.gaps), decider)