feat: keep an unchanged description, list conditions, review coverage with Jev

After case 02 (completed at 100%, but with two Revisions of the Target
architecture for gaps validation found one pass at a time):

- A Deliverable stands while what it was written from is unchanged. The
  architecture description is written from the Elements and Relationships,
  so a Revision that only adds or rewords Checks no longer runs the describer.
- Non-functional requirements and recommendations list their conditions,
  one entry per separate thing that must be true; submission requires them.
- A coverage review at submission (JEV_COVERAGE_REVIEW, off by default):
  for each condition, Jev chooses which Check verifies it, or none. Asked as
  one broad yes-or-no per requirement it could not tell a complete design
  from one with known gaps; asked as a choice per condition it raised all
  four known gaps of case 02 and nothing on the complete graph. An opt-in
  live test (LIVE_JEV=1) repeats that.
- The validator is told to report every gap in its first pass.

Plans record the case 02 run and both forms of the review with figures.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-07 20:58:38 +01:00
parent f1f6f1b83a
commit 5adc911a82
29 changed files with 1687 additions and 16 deletions

View File

@@ -665,3 +665,51 @@ async def test_the_orchestrator_is_told_what_validation_decided(tmp_path):
run for run in runtime.runs if run.role == specialist(K.DEPLOYMENT_GUIDANCE)
][1]
assert revised.task.context["feedback"] == ["K-1 failed: min instances is 1"]
# --- constraints list their conditions --------------------------------------------------
def test_a_non_functional_requirement_must_list_its_conditions():
requirements = [
{"id": "FR-1", "kind": "functional", "text": "Accept events."},
{"id": "NFR-1", "kind": "non_functional", "text": "Encrypted and retained."},
{
"id": "NFR-2",
"kind": "non_functional",
"text": "Available.",
"conditions": [],
},
]
args = sample_submission(K.REQUIREMENTS).args
missing = check_submission(
K.REQUIREMENTS,
args["content"],
{"requirements.json": json.dumps(requirements)},
)
needs = (
"needs `conditions`: a list with one entry for each separate thing it asks for"
)
assert missing == (
f"requirements.json: NFR-1 {needs}",
f"requirements.json: NFR-2 {needs}",
)
def test_a_recommendation_must_list_its_conditions():
recommendations = json.loads(SAMPLE_DATA["recommendations.json"])
del recommendations[0]["conditions"]
args = sample_submission(K.DESIGN_RECOMMENDATIONS).args
missing = check_submission(
K.DESIGN_RECOMMENDATIONS,
args["content"],
{"recommendations.json": json.dumps(recommendations)},
)
needs = (
"needs `conditions`: a list with one entry for each separate thing it asks for"
)
assert missing == (f"recommendations.json: DR-1 {needs}",)