feat: all four evaluation cases pass; intake, checklist review, thresholds
Case 04 (interactive) - A scripted answer may name who it is for, so facts written for requirements discovery are not given to a Specialist confirming a draft. - A reply that restates what the agreed requirements already say is read as an answer, not a request for changes. - With a user present, a first submission is refused until the user has been shown a draft of that Deliverable (CONFIRM_DRAFTS). Routing and reviews - Intake: a message that starts something is read first. A question is answered and starts nothing; a change to delivered work starts as a new request with a note, until Change requests are built. - Requirements and recommendations list what infrastructure code can show (conditions) apart from what it cannot (outside_code); the latter needs no Check and validation proposes nothing for it. - A requirements review, "names no products", behind its own switch (off). - Each pillar advisor reviews its pillar's checklist; the engine writes the reviews into the design recommendations. The judged checklist check went from 9-45% a pillar to 100% in one run of case 04. Evaluation - Per-case thresholds for Revisions, seconds and tokens, set from every completed run on this build. - A progress file after every agent run, so an interrupted run keeps its time and tokens. - eval/calibrate_judge.py with a 32-question set awaiting a person's labels. Unlabelled: Jev stable at 1.00, Gemini 0.92, agreeing on 0.91. Smaller - An Execution that ends with warnings writes its Deliverables, with the warnings and each status in the manifest. - CI installs the application's dependencies before linting and testing. - A load-balancer pattern in the IaC patterns Skill. Plans record nine runs of 2026-10-08. Iteration 6 is complete. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -204,3 +204,27 @@ Every step ends with the full suite passing. Steps that change agent behaviour (
|
||||
- **Where:** `app/tools/schema_review.py` (new), the assembly in `app/agent.py`, `agents/target-architect.md`.
|
||||
- **Acceptance criteria:** At submission, every setting a Check's statement names is looked up on its Element's resource type, and a resource type the provider lacks is reported. What is raised is returned once and never blocks. On designs that passed validation it raises little or nothing.
|
||||
|
||||
## Step 25: An Execution that ends with warnings keeps its files
|
||||
|
||||
- **Report ref:** none; found by the runs of 2026-10-07 and 08
|
||||
- **Capability:** What an unfinished Execution produced can be read afterwards.
|
||||
- **Rationale:** Only a completed Execution wrote its Deliverables. Case 04's first run ended with warnings after 53 minutes and left nothing on disk: nine Deliverables' worth of work, and the evidence of what went wrong, existed only in the report's conversation log.
|
||||
- **Where:** `_write_outputs` and `end_with_warnings` in `app/nodes/execution_nodes.py`.
|
||||
- **Acceptance criteria:** An Execution that ends with warnings writes every Deliverable it holds, with a manifest that carries the warnings, each Deliverable's status and each Phase's status, so nothing unapproved reads as final. The case's history points to the files.
|
||||
|
||||
## Step 26: Each pillar's checklist is reviewed and the review is in the Deliverable
|
||||
|
||||
- **Report ref:** none; found by the judged runs of 2026-10-08
|
||||
- **Capability:** An architect sees every item of each pillar's checklist accounted for: addressed, and how, or not applicable, and why.
|
||||
- **Rationale:** The judged check `pillar_checklists_covered` failed in all four cases of the judged batch, at 0% to 55% a pillar, while `recommendations_quality` passed at 0.83 to 0.90. The six checklists hold 78 items; a run produces 11 to 14 recommendations, each one configurable decision. Twelve recommendations cannot answer 78 items, many of which are an organisation's process and not a design decision, so the check could not pass and nothing told an architect which items had been considered.
|
||||
- **Where:** `app/tools/pillars.py`, `submit_deliverable` in `app/tools/execution.py`, `agents/pillar-advisor.md`, `agents/design-advisor.md`.
|
||||
- **Acceptance criteria:** Each pillar advisor returns, with its advice, a status and a note for every item of its Skill's checklist. The reviews are kept with the advice across Revisions and written into the design recommendations by code, once. On a judged run `pillar_checklists_covered` passes.
|
||||
|
||||
## Step 27: A user sees a Deliverable before it is first submitted
|
||||
|
||||
- **Report ref:** none; found by evaluation case 04 on 2026-10-08
|
||||
- **Capability:** With a user present, no Deliverable is submitted that they have not been shown.
|
||||
- **Rationale:** The Specialist protocol tells every Specialist to confirm its draft with the user before submitting. In case 04 the validator did not (first run), and the target architect did not after running out of tool calls on an earlier attempt (batch A). An instruction was not enough.
|
||||
- **Where:** `submit_deliverable` in `app/tools/execution.py`, `specialist_task` in `app/nodes/execution_nodes.py`, `CONFIRM_DRAFTS` in `app/config.py`.
|
||||
- **Acceptance criteria:** In an Execution with a user, a Specialist's submission is refused until the user has replied to it about that Deliverable at least once, and the refusal says how to ask. A pre-approved Execution is unaffected. It can be switched off.
|
||||
|
||||
|
||||
@@ -4,7 +4,7 @@
|
||||
**Intent:** Make the agent a learning, adaptable solution through Skills. Fix the cheap defects the 2026-10-06 review found, then close the loop so each Execution can improve the next through a reviewed Skill change, then let new standards, clients and Cloud providers arrive as Skills and configuration.
|
||||
**Status:** steps 1 to 8, 11, 13 and 15 to 20 built; case 01 completed on them on 2026-10-07 (`../iter-06-target-architecture-graph/steps/step-11.md`); the other cases have not run, so no criterion is measured across the benchmark; step 9 complete (ADR-0004 accepted 2026-10-08), which unblocks steps 10 and 12; steps 10, 12 and 14 planned. Steps 1 to 6 are in commit `7ee49ab`; the rest are uncommitted.
|
||||
**Changed by iteration 6:** `docs/adr/0005-the-target-architecture-is-an-explicit-graph.md` (accepted 2026-10-07) replaces the free-form `findings.json` of step 1 with a verdict per Check, remove the diagrammer, and add a Phase. Its plan is `../iter-06-target-architecture-graph/`, which lists the effect on each step here and should be built before steps 10 to 14.
|
||||
**This directory covers:** steps 1 to 24
|
||||
**This directory covers:** steps 1 to 27
|
||||
|
||||
## Sources of truth
|
||||
|
||||
@@ -19,12 +19,12 @@
|
||||
|---|---|---|---|---|
|
||||
| 1 | Structured validator findings | A | S | replaced by iteration 6 step 9 (verdicts per Check) |
|
||||
| 2 | Carry the draft through `needs_input` | A | S | complete |
|
||||
| 3 | Reuse pillar advice across Revisions | A | S | built; evaluation run outstanding |
|
||||
| 3 | Reuse pillar advice across Revisions | A | S | built; no run has revised design recommendations, so unexercised by evaluation |
|
||||
| 4 | Single source for Deliverable contracts | A | S | complete |
|
||||
| 5 | Cap parallel Specialists | A | S | complete |
|
||||
| 6 | Orchestrator step order | A | S | built; seen working in one stopped run, no completed evaluation |
|
||||
| 7 | Capture lesson candidates | B | M | complete |
|
||||
| 8 | Evaluation that can see improvement | B | M | built; thresholds and a judged run outstanding |
|
||||
| 8 | Evaluation that can see improvement | B | M | complete: thresholds set and four judged runs done on 2026-10-08 |
|
||||
| 9 | ADR: the lessons loop and overlay Skills | B | S | complete: ADR-0004 accepted 2026-10-08 |
|
||||
| 10 | Lessons Skill and lesson curator | B | L | planned |
|
||||
| 11 | IaC patterns Skill | B | M | built; in case 01 the IaC author fell from 57 requests to 11 with no Revision; other cases unmeasured |
|
||||
@@ -41,6 +41,9 @@
|
||||
| 22 | Validation reports every gap in one pass | added | S | instructions changed; with conditions listed, case 02 ran with 102 Checks and no Revision |
|
||||
| 23 | Validation recorded a few verdicts at a time | added | S | built; in case 02 a validator run cut short carried on and submitted in 68 seconds, with no timeout |
|
||||
| 24 | The design checked against the provider's schema, in code | added | S | built; measured on two passed designs and the known faults; raised nothing in case 02, which had no unimplementable Check |
|
||||
| 25 | An Execution that ends with warnings keeps its files | added | S | complete |
|
||||
| 26 | Each pillar's checklist is reviewed and the review is in the Deliverable | added | S | built; a judged run of case 04 scored the checklist check at 100% on every pillar |
|
||||
| 27 | A user sees a Deliverable before it is first submitted | added | S | built; a hole found by a run and closed; not rerun |
|
||||
|
||||
Size: S under a day, M a few days, L a week or more. Group A is cheap fixes that also create signal. Group B is the learning loop. Group C is adaptability.
|
||||
|
||||
|
||||
@@ -10,4 +10,7 @@ Differs from the plan: the plan's acceptance is a fall in IaC author Revisions o
|
||||
|
||||
Tests: `tests/test_iac_patterns.py` runs `terraform validate` on every reference's pattern with the Skill's own versions file (13 pass against the real provider from the plugin cache; skipped when the provider cannot be installed), checks every reference is listed in `SKILL.md`, and checks the Skill and the bundle pin the same version.
|
||||
|
||||
Not done: load balancing, Firestore, BigQuery, Eventarc and GKE have no reference. A product with none is written from `terraform_schema` and the documentation.
|
||||
Not done: Firestore, BigQuery, Eventarc and GKE have no reference. A product with none is written from `terraform_schema` and the documentation.
|
||||
|
||||
Added on 2026-10-08: `references/load-balancer.md`, a fourteenth pattern: an external Application Load Balancer in front of Cloud Run with a TLS policy, a firewall policy, Identity-Aware Proxy and an HTTP redirect. Cases 02, 03 and 04 all used a load balancer with no pattern, and one run put `ssl_policy` on a backend service, which has no such setting; the reference says which link of the chain each setting lives on. It validates against the pinned provider.
|
||||
|
||||
|
||||
14
.agents/plans/iter-04-learning-and-skills/steps/step-25.md
Normal file
14
.agents/plans/iter-04-learning-and-skills/steps/step-25.md
Normal file
@@ -0,0 +1,14 @@
|
||||
# Step 25 — Implementation Detail
|
||||
|
||||
Built on 2026-10-08.
|
||||
|
||||
1. `_write_outputs` takes the Execution's final status and its Ledger. `end_with_warnings` now calls it, as `finalize` does.
|
||||
2. `execution.json` gains `status` (`completed` or `completed_with_warnings`), `warnings`, `phases` (each Phase's status), and a `status` on every Deliverable: `submitted`, or `draft` when something it depends on was reopened after it was written.
|
||||
3. With no Deliverable at all nothing is written, and the case's history records no files, as before.
|
||||
4. The solution guide is written only when it exists; an Execution that stopped before packaging has none, and the manifest says so.
|
||||
|
||||
Not covered: an Execution whose process is killed. It never reaches either end node, so it still writes nothing. The evaluation's progress file (iteration 6 step 11) records its time and tokens, not its Deliverables.
|
||||
|
||||
Also on 2026-10-08, outside any step: the CI workflow installs `requirements.txt` and `requirements-dev.txt` before linting and testing. It installed only ruff, mypy and pytest, so its test step could not import the application.
|
||||
|
||||
Tests: `tests/execution/test_engine.py`, two updated.
|
||||
17
.agents/plans/iter-04-learning-and-skills/steps/step-26.md
Normal file
17
.agents/plans/iter-04-learning-and-skills/steps/step-26.md
Normal file
@@ -0,0 +1,17 @@
|
||||
# Step 26 — Implementation Detail
|
||||
|
||||
Built on 2026-10-08.
|
||||
|
||||
1. `submit_advice` takes a `checklist`: one entry per item of the pillar Skill's validation checklist, with `status` (`addressed`, `not_applicable` or `not_addressed`) and a `note`. An entry with no item or another status is dropped.
|
||||
2. The consultation keeps each pillar's review in the Deliverable's working memory (`pillar_checklists`) beside its advice, so a Revision that re-consults some pillars keeps the others' reviews. The design advisor is given the advice only, not the review.
|
||||
3. `render_checklist_review` writes the reviews as one section, "Architecture framework checklist review", a table per pillar. `submit_deliverable` appends it to the design recommendations and replaces an earlier copy, so a Revision never stacks two.
|
||||
4. A Skill with no checklist gets no review and the Deliverable no section: the mechanism is the provider's Skills' own, not Google Cloud's.
|
||||
|
||||
Checked on 2026-10-08 with two real advisors on case 03's brief: reliability returned all 8 of its items (6 addressed, 2 not applicable) and cost optimisation all 11 (11 addressed), in 74 seconds for the pair.
|
||||
|
||||
Two limits:
|
||||
|
||||
- A review says what the advisor's own advice covers. The design advisor reconciles the pillars and may leave something out, so "addressed" there is the advisor's claim, not a check of the final recommendations.
|
||||
- A judged run of case 04 on 2026-10-08 scored `pillar_checklists_covered` at 100% on all six pillars, against 9% to 45% before. One run.
|
||||
|
||||
Tests: `tests/execution/test_pillars.py`, "each advisor reviews its pillar's checklist" (3).
|
||||
13
.agents/plans/iter-04-learning-and-skills/steps/step-27.md
Normal file
13
.agents/plans/iter-04-learning-and-skills/steps/step-27.md
Normal file
@@ -0,0 +1,13 @@
|
||||
# Step 27 — Implementation Detail
|
||||
|
||||
Built on 2026-10-08.
|
||||
|
||||
1. `specialist_tools` takes `confirm_first`. While it is set, `submit_deliverable` checks the submission as usual, keeps the working copy, runs any review, and then refuses: the user has not seen this Deliverable; call `needs_input` with a summary and pass the content as `draft`.
|
||||
2. `specialist_task` sets it when the Execution is not pre-approved and the user has not been shown a draft of the Deliverable. The Orchestrator's turn records a Deliverable in `drafts_shown` when a Specialist's question carries a draft. Once shown, submission is allowed, so a Revision is not asked about again.
|
||||
|
||||
The first version opened the rule once the user had answered any question about the Deliverable. The verification run of 2026-10-08 showed the hole: the target architect ran out of tool calls, the Orchestrator asked the user how to proceed, and that answer let the next attempt submit unseen.
|
||||
3. `CONFIRM_DRAFTS` (default `true`) turns the rule on in the assembly. The engine's own default is off, so an engine built directly, as in tests, behaves as before.
|
||||
|
||||
**No interactive evaluation has run since the second version.** The case 04 check `specialists_ask_before_submitting` is the measure.
|
||||
|
||||
Tests: `tests/execution/test_engine.py`, "a user sees a Deliverable before it is first submitted" (3).
|
||||
Reference in New Issue
Block a user