chore: housekeeping from the runs of 2026-10-09
Some checks failed
validation / verify (push) Failing after 12s

- An Execution's files are written as each Deliverable is submitted, marked
  in_progress, so a killed process or one waiting for its user leaves them on
  disk. A write removes files an earlier write left that it no longer has.
- A question about delivered work is answered from that Execution's solution
  guide by the reply writer; a question about the service is answered as
  before. Nothing is started for either.
- Lessons: prove writes only for lessons the Skill holds; the Skill records
  the vendored Skill versions the lessons were read against, status names any
  that changed, and a test fails until they are reviewed.
- Four more code patterns: Firestore, BigQuery, Eventarc and GKE.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-10 11:44:38 +01:00
parent 10d23a5f91
commit 71da0ed504
24 changed files with 1109 additions and 43 deletions

View File

@@ -31,7 +31,15 @@ from google.protobuf import json_format
from app.agent import ExecutionEngine, Interaction
from app.nodes.execution_nodes import GUIDE_FILENAME
from app.nodes.intake import ABOUT, CHANGE_REQUEST, QUESTION, Intake, change_note
from app.nodes.intake import (
ABOUT,
CHANGE_REQUEST,
QUESTION,
DeliveredAnswers,
Intake,
change_note,
no_answer_note,
)
from app.presentation import describe_prompt
from app.workflows.deliverables import DeliverableKind
@@ -41,7 +49,13 @@ STRUCTURED_REPLY_KEYS = ("approval", "permission")
class SolutionArchitectExecutor(AgentExecutor):
def __init__(self, engine: ExecutionEngine, intake: Intake | None = None) -> None:
def __init__(
self,
engine: ExecutionEngine,
intake: Intake | None = None,
answers: DeliveredAnswers | None = None,
) -> None:
self._answers = answers
self._engine = engine
self._intake = intake
@@ -75,14 +89,21 @@ class SolutionArchitectExecutor(AgentExecutor):
scope=task_id,
)
if reading.kind == QUESTION:
text, about = ABOUT, None
if reading.about_delivered and reading.latest and self._answers:
# About what was delivered: answered from its files.
about = reading.latest
text = await self._answers.answer(
context.get_user_input(),
str(options.get("customer_case")),
about,
) or no_answer_note(about)
data = {"status": "answered", "intake": QUESTION}
if about:
data["about"] = about
await updater.complete(
updater.new_agent_message(
[
new_text_part(ABOUT),
new_data_part(
{"status": "answered", "intake": QUESTION}
),
]
[new_text_part(text), new_data_part(data)]
)
)
return