latest refactoring
Some checks failed
validation / verify (push) Failing after 10s

This commit is contained in:
2026-10-06 20:22:37 +01:00
parent e94b2493e7
commit 7ee49ab352
414 changed files with 15768 additions and 3896 deletions

View File

@@ -0,0 +1,7 @@
# Step 1 — Implementation Detail
1. Created `.venv/` on Python 3.12.3 and installed both requirements files. `google-adk` resolved to 2.9.0, `langgraph` to 1.2.11.
2. Recorded the baseline: 30 tests passed across the iteration 1 suite.
3. Found that the iteration 1 "ADK" layer never used `google-adk`: `HAS_NATIVE_ADK` stayed false even with the package installed.
Full record: spec `## Comments`, "2026-09-15 · Increment 1".

View File

@@ -0,0 +1,7 @@
# Step 2 — Implementation Detail
1. Vendored 7 upstream Skills (solution architecture plus six Well-Architected Framework pillars) at commit `81a31a6`, with checksums verified by `tests/test_vendored_skills.py`.
2. Added the provider bundle `providers/gcp.yaml` and its loader, and the Agent Skills frontmatter validator.
3. Suite: 65 passed.
Full record: spec `## Comments`, "2026-09-15 · Increment 2".

View File

@@ -0,0 +1,8 @@
# Step 3 — Implementation Detail
1. Declared 9 Deliverables in 4 Phases as data, with section and attachment contracts checked by `check_submission`.
2. Built the Ledger as pure code with no I/O, serialisable into graph state.
3. `technical_decomposition` and `architecture_description` were left with a non-empty-content contract only. Iteration 4 step 4 revisits this.
4. Suite: 102 passed.
Full record: spec `## Comments`, "2026-09-15 · Increment 3".

View File

@@ -0,0 +1,9 @@
# Step 4 — Implementation Detail
1. Built the graph test-first: `orchestrator_turn`, parallel `specialist_task` via `Send`, `await_user` via `interrupt`, `finalize`, `end_with_warnings`.
2. Added `ExecutionEngine` (`start`, `resume`, `interaction`) as the single interface; the graph is an internal detail behind it.
3. Added the `Stopped` outcome, the single-writer rule for Specialist outcomes, and `MAX_ORCHESTRATOR_TURNS` as the loop guard.
4. Verified the tests bite by breaking the cloud-read gate, the permission prompt, question relay and the submission contract in turn; each break failed a test.
5. Suite: 121 passed.
Full record, including prompt and reply shapes: spec `## Comments`, "2026-09-15 · Increment 4".

View File

@@ -0,0 +1,8 @@
# Step 5 — Implementation Detail
1. Implemented `AdkAgentRuntime`: a fresh `LlmAgent` and in-memory session per run, tool-call budgets, and nudges when an agent stops without ending its turn.
2. Wrote the 11 role files and the shared Specialist protocol; the role loader rejects any field the bundle should own.
3. Added the design advisor's fan-out to six pillar advisors.
4. Suite: 158 passed.
Full record: spec `## Comments`, "2026-09-16 · Increment 5".

View File

@@ -0,0 +1,9 @@
# Step 6 — Implementation Detail
1. Added local tools `mermaid_check`, `terraform_fmt`, `terraform_validate` and `terraform_plan`, each running on a scratch copy.
2. Added the remote MCP catalog with Application Default Credentials and per-server allowlists, reviewed on 2026-09-16 against each server's live tool list.
3. Excluded data-content tools even where read-only (SQL queries, object reads, generic Kubernetes reads).
4. Wrote the `cloud-discovery` and `iac-validation` Skills.
5. Suite: 189 passed.
Full record: spec `## Comments`, "2026-09-16 · Increment 6".

View File

@@ -0,0 +1,7 @@
# Step 7 — Implementation Detail
1. Added the A2A server (JSON-RPC at `/a2a`, agent card, `/health`) and the executor that maps A2A tasks to Executions and their prompts.
2. Kept `/generate` as a pre-approved one-shot Execution.
3. Suite: 206 passed.
Full record: spec `## Comments`, "2026-09-16 · Increment 7".

View File

@@ -0,0 +1,22 @@
# Step 8 — Implementation Detail
This step has no entry in the spec's comments; this file is its record.
1. Added `eval/solution_eval.py`: runs each case as a pre-approved Execution through the full assembly with real models, counting agent runs, outcomes, seconds and tokens per role.
2. Added `eval/scoring.py` with 8 checks: completed, guide follows the template, required products selected, alternatives listed, documentation cited, requirements name no products, diagram is valid Mermaid, Terraform validates.
3. Added 3 cases in `eval/datasets/solution_cases.json`. Results are written to `eval/results/<timestamp>/` (gitignored).
Recorded runs:
| Run | Case | Score | Seconds | Revisions |
|---|---|---|---|---|
| 2026-09-16 10:57Z | case-01-event-driven-http | 1.0 | 2,932 | design_recommendations × 2 |
| 2026-09-17 08:44Z | case-03-internal-web-app | 1.0 | 2,623 | deployment_guidance × 3 |
No scored run of `case-02-high-scale-ingestion` is on record.
Case 03 used 3.27 million tokens over 127 model requests. By role: IaC author 812 thousand, validator 618 thousand, describer 513 thousand, Orchestrator 356 thousand, product selector 345 thousand. These figures are the evidence base for iterations 4 and 5.
All 8 checks are structural, so a better or worse Skill scores the same. Iteration 4 step 8 addresses that.
Suite at the end of this step: 226 passed.