feat: consult only the pillars a change affects directly (iteration 5 step 3)
A graded question per pillar (not at all, only indirectly, directly) picks the pillar advisors to consult again on a Revision or a Change request; the design advisor is told which, and keeps its earlier advice for the rest. As a yes or no the answer was yes for nearly every pillar of every change. A completed Execution now writes working.json with each pillar's advice and checklist review, and a Change request starts from its Baseline's, so only the pillars a change touches are consulted afresh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -408,3 +408,59 @@ async def test_with_no_review_nothing_is_added():
|
||||
result = await submit.handler(**sample_submission(kind).args)
|
||||
|
||||
assert REVIEW_HEADING not in result.outcome.content
|
||||
|
||||
|
||||
# --- only the pillars a change touches are consulted again -------------------------------
|
||||
|
||||
|
||||
async def test_a_change_names_the_pillars_it_affects_directly():
|
||||
from app.adk.fake_runtime import FakeDecider
|
||||
from app.adk.runtime import Answer
|
||||
from app.tools.pillars import pillars_touched
|
||||
|
||||
decider = FakeDecider(
|
||||
{
|
||||
"security": Answer(1.9, 0.9),
|
||||
"reliability": Answer(1.0, 0.6),
|
||||
"sustainability": Answer(0.2, 0.8),
|
||||
}
|
||||
)
|
||||
|
||||
chosen = await pillars_touched(
|
||||
decider, list(PILLARS), "Use customer-managed keys.", scope="e1"
|
||||
)
|
||||
|
||||
state, questions, scope = decider.asked[0]
|
||||
assert chosen == ["security"]
|
||||
assert scope == "e1" and state.endswith("Use customer-managed keys.")
|
||||
assert questions["security"].kind == "score"
|
||||
assert questions["security"].options == (
|
||||
"not at all",
|
||||
"only indirectly",
|
||||
"directly",
|
||||
)
|
||||
|
||||
|
||||
async def test_a_change_that_touches_no_pillar_is_an_answer_and_no_decision_is_not():
|
||||
from app.adk.fake_runtime import FakeDecider
|
||||
from app.adk.runtime import Answer, NoDecider
|
||||
from app.tools.pillars import pillars_touched
|
||||
|
||||
nothing = FakeDecider(dict.fromkeys(PILLARS, Answer(0.0, 0.99)))
|
||||
|
||||
assert await pillars_touched(nothing, list(PILLARS), "Rename a page.") == []
|
||||
assert await pillars_touched(NoDecider(), list(PILLARS), "Rename a page.") is None
|
||||
assert await pillars_touched(nothing, list(PILLARS), " ") is None
|
||||
|
||||
|
||||
async def test_an_empty_list_of_pillars_consults_none_and_returns_what_was_said():
|
||||
memory: dict = {}
|
||||
runtime = FakeAgentRuntime({PILLAR_ADVISOR: [turn_for_pillar] * 3})
|
||||
tool = pillar_consultation_tool(runtime, ADVISOR, PILLARS, memory=memory)
|
||||
await consult(tool, brief="b")
|
||||
|
||||
again = await consult(tool, brief="b", pillars=[])
|
||||
|
||||
assert len(runtime.runs) == 3 # nobody was consulted a second time
|
||||
for pillar in PILLARS:
|
||||
assert f"## {pillar} (from your earlier consultation)" in again.message
|
||||
|
||||
Reference in New Issue
Block a user