feat: the lessons loop, and six lessons approved and published
Capture, distil, review, publish, retire (ADR-0004). Lesson candidates of past Executions are grouped into what recurred; a lesson-curator role, outside any Execution, proposes a lesson per group worth one; each proposal is an issue file a person approves or rejects; an approved lesson is written into the provider's lessons Skill, which a Specialist is given only once it holds lessons for that Specialist's Deliverable. LESSONS_ENABLED off runs without them, for an evaluation with and without. The curator proposed six lessons from 21 Executions. The owner approved all six on 2026-10-09 and they are published: five for the target architect, one for the IaC author. None is proved by an evaluation yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,27 @@
|
||||
# L-01: Create Specific Checks for All Constraints
|
||||
|
||||
Status: ready-for-agent
|
||||
Deliverable: target_architecture
|
||||
Evidence-key: 13ebd6fd65
|
||||
Proposed: 2026-10-09
|
||||
Published: 2026-10-09
|
||||
|
||||
## Rule
|
||||
|
||||
Create specific Checks for every explicit constraint, metric, or capability mentioned in a requirement, rather than relying on a single broad Check.
|
||||
|
||||
## Why
|
||||
|
||||
If detailed constraints are missed, the validation phase will reject the design for incomplete coverage, forcing a revision.
|
||||
|
||||
## Evidence
|
||||
|
||||
Seen in 14 of 21 Executions, 58 times in all: validation proposed a Check the design lacked.
|
||||
|
||||
## Proof
|
||||
|
||||
Not yet measured.
|
||||
|
||||
## Comments
|
||||
|
||||
Approved by the owner on 2026-10-09.
|
||||
27
.scratch/lessons/issues/02-assign-checks-to-every-element.md
Normal file
27
.scratch/lessons/issues/02-assign-checks-to-every-element.md
Normal file
@@ -0,0 +1,27 @@
|
||||
# L-02: Assign Checks to Every Element
|
||||
|
||||
Status: ready-for-agent
|
||||
Deliverable: target_architecture
|
||||
Evidence-key: 93d74c1245
|
||||
Proposed: 2026-10-09
|
||||
Published: 2026-10-09
|
||||
|
||||
## Rule
|
||||
|
||||
Give every Element at least one Check before you submit.
|
||||
|
||||
## Why
|
||||
|
||||
The submission tool will reject the architecture if any Element lacks a Check, wasting an attempt.
|
||||
|
||||
## Evidence
|
||||
|
||||
Seen in 13 of 21 Executions, 13 times in all: submit_deliverable refused: Not submitted. The Deliverable is missing: target-architecture.json: Element … has no Check; target-architectu.
|
||||
|
||||
## Proof
|
||||
|
||||
Not yet measured.
|
||||
|
||||
## Comments
|
||||
|
||||
Approved by the owner on 2026-10-09.
|
||||
@@ -0,0 +1,27 @@
|
||||
# L-03: Verify Resource Arguments for Checks
|
||||
|
||||
Status: ready-for-agent
|
||||
Deliverable: target_architecture
|
||||
Evidence-key: f1e7c68393
|
||||
Proposed: 2026-10-09
|
||||
Published: 2026-10-09
|
||||
|
||||
## Rule
|
||||
|
||||
Verify that the specific resource type used for an Element actually supports the configuration argument you specify in a Check. Remember that access policies and certain configurations often require entirely separate resources.
|
||||
|
||||
## Why
|
||||
|
||||
If a Check specifies an argument that does not exist on the resource, it cannot be implemented, forcing an architectural revision.
|
||||
|
||||
## Evidence
|
||||
|
||||
Seen in 3 of 21 Executions, 3 times in all: revised because a Check named something its resource cannot do.
|
||||
|
||||
## Proof
|
||||
|
||||
Not yet measured.
|
||||
|
||||
## Comments
|
||||
|
||||
Approved by the owner on 2026-10-09.
|
||||
@@ -0,0 +1,27 @@
|
||||
# L-04: Avoid Using Values as Setting Names
|
||||
|
||||
Status: ready-for-agent
|
||||
Deliverable: target_architecture
|
||||
Evidence-key: 22ff1f5fed
|
||||
Proposed: 2026-10-09
|
||||
Published: 2026-10-09
|
||||
|
||||
## Rule
|
||||
|
||||
When writing a Check for a configuration block that takes a name and value, explicitly state the block's argument name instead of writing the expected value as if it were the setting itself.
|
||||
|
||||
## Why
|
||||
|
||||
Automated reviews may mistake specific expected values for invalid setting names, causing warnings and submission delays.
|
||||
|
||||
## Evidence
|
||||
|
||||
Seen in 2 of 21 Executions, 4 times in all: submit_deliverable refused: Not submitted. A review found: Check …: google_sql_database_instance has no setting named cloudsql.iam_authent.
|
||||
|
||||
## Proof
|
||||
|
||||
Not yet measured.
|
||||
|
||||
## Comments
|
||||
|
||||
Approved by the owner on 2026-10-09.
|
||||
@@ -0,0 +1,27 @@
|
||||
# L-05: Include Required Arguments in Alert Policies
|
||||
|
||||
Status: ready-for-agent
|
||||
Deliverable: deployment_guidance
|
||||
Evidence-key: 2d4ff48141
|
||||
Proposed: 2026-10-09
|
||||
Published: 2026-10-09
|
||||
|
||||
## Rule
|
||||
|
||||
Always verify and include all required arguments (such as time window definitions) when configuring nested blocks in monitoring alert policies.
|
||||
|
||||
## Why
|
||||
|
||||
Missing required arguments in nested blocks will cause Terraform validation to fail, preventing submission.
|
||||
|
||||
## Evidence
|
||||
|
||||
Seen in 2 of 21 Executions, 2 times in all: terraform_validate refused: terraform validate failed: Error: Missing required argument on main.tf line …, in resource … …: …: condition_m.
|
||||
|
||||
## Proof
|
||||
|
||||
Not yet measured.
|
||||
|
||||
## Comments
|
||||
|
||||
Approved by the owner on 2026-10-09.
|
||||
@@ -0,0 +1,27 @@
|
||||
# L-06: Do Not Mark Requirements as Not Applicable
|
||||
|
||||
Status: ready-for-agent
|
||||
Deliverable: target_architecture
|
||||
Evidence-key: cd5ae98124
|
||||
Proposed: 2026-10-09
|
||||
Published: 2026-10-09
|
||||
|
||||
## Rule
|
||||
|
||||
Do not list Requirements in the not applicable field, as this field is strictly for Design Recommendations. Ensure every Requirement has at least one Check.
|
||||
|
||||
## Why
|
||||
|
||||
The submission tool will reject the deliverable if a Requirement lacks a Check or is incorrectly marked as not applicable.
|
||||
|
||||
## Evidence
|
||||
|
||||
Seen in 2 of 21 Executions, 2 times in all: submit_deliverable refused: Not submitted. The Deliverable is missing: Requirement … has no Check; Requirement … has no Check; Requirement.
|
||||
|
||||
## Proof
|
||||
|
||||
Not yet measured.
|
||||
|
||||
## Comments
|
||||
|
||||
Approved by the owner on 2026-10-09.
|
||||
Reference in New Issue
Block a user