feat: add the Deliverable dependency graph and Ledger
Increment 3 of .scratch/solution-architect-agent/spec.md, test-first. - app/execution/deliverables.py: four Phases, nine Deliverables and their Dependencies declared once, plus per-kind contracts (required headings, attachments) checked by check_submission. - app/execution/ledger.py: pure Ledger enforcing both acceptance thresholds, Phase Approvals (including pre-approved mode and change requests), Revision cascade with withdrawn Approvals, the revision cap with escalation and user override, attempt numbers that reject stale submissions, an ordered event log, and dict round-tripping. - 37 new tests; full suite 102 passed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
155
tests/execution/test_deliverables.py
Normal file
155
tests/execution/test_deliverables.py
Normal file
@@ -0,0 +1,155 @@
|
||||
"""The dependency graph and Deliverable contracts."""
|
||||
|
||||
import pytest
|
||||
|
||||
from app.execution.deliverables import (
|
||||
DEPENDENCY_GRAPH,
|
||||
PHASE_ORDER,
|
||||
DeliverableKind,
|
||||
PhaseId,
|
||||
check_submission,
|
||||
deliverables_in,
|
||||
)
|
||||
|
||||
|
||||
def test_every_kind_is_declared_once_with_known_dependencies():
|
||||
assert set(DEPENDENCY_GRAPH) == set(DeliverableKind)
|
||||
for kind, spec in DEPENDENCY_GRAPH.items():
|
||||
assert spec.kind is kind
|
||||
assert set(spec.depends_on) <= set(DeliverableKind), kind
|
||||
|
||||
|
||||
def test_dependencies_never_point_to_a_later_phase_and_form_no_cycle():
|
||||
position = {phase: index for index, phase in enumerate(PHASE_ORDER)}
|
||||
for spec in DEPENDENCY_GRAPH.values():
|
||||
for dependency in spec.depends_on:
|
||||
assert position[DEPENDENCY_GRAPH[dependency].phase] <= position[spec.phase]
|
||||
|
||||
visiting: set[DeliverableKind] = set()
|
||||
done: set[DeliverableKind] = set()
|
||||
|
||||
def visit(kind: DeliverableKind) -> None:
|
||||
assert kind not in visiting, f"cycle through {kind}"
|
||||
if kind in done:
|
||||
return
|
||||
visiting.add(kind)
|
||||
for dependency in DEPENDENCY_GRAPH[kind].depends_on:
|
||||
visit(dependency)
|
||||
visiting.discard(kind)
|
||||
done.add(kind)
|
||||
|
||||
for kind in DeliverableKind:
|
||||
visit(kind)
|
||||
|
||||
|
||||
def test_every_phase_groups_at_least_one_deliverable_with_a_distinct_specialist():
|
||||
assert PHASE_ORDER == (
|
||||
PhaseId.REQUIREMENTS_DISCOVERY,
|
||||
PhaseId.SOLUTION_ARCHITECTURE,
|
||||
PhaseId.SOLUTION_VALIDATION,
|
||||
PhaseId.PACKAGING,
|
||||
)
|
||||
for phase in PHASE_ORDER:
|
||||
assert deliverables_in(phase), phase
|
||||
specialists = [spec.specialist for spec in DEPENDENCY_GRAPH.values()]
|
||||
assert len(specialists) == len(set(specialists))
|
||||
|
||||
|
||||
def test_graph_matches_the_upstream_skill_dependencies():
|
||||
depends = {kind: set(spec.depends_on) for kind, spec in DEPENDENCY_GRAPH.items()}
|
||||
K = DeliverableKind
|
||||
|
||||
assert depends[K.REQUIREMENTS] == set()
|
||||
assert depends[K.TECHNICAL_DECOMPOSITION] == {K.REQUIREMENTS}
|
||||
assert depends[K.PRODUCT_SELECTION] == {K.TECHNICAL_DECOMPOSITION}
|
||||
assert depends[K.ARCHITECTURE_DIAGRAM] == {K.PRODUCT_SELECTION}
|
||||
assert depends[K.ARCHITECTURE_DESCRIPTION] == {
|
||||
K.ARCHITECTURE_DIAGRAM,
|
||||
K.PRODUCT_SELECTION,
|
||||
}
|
||||
assert depends[K.DESIGN_RECOMMENDATIONS] == {K.PRODUCT_SELECTION, K.REQUIREMENTS}
|
||||
assert depends[K.DEPLOYMENT_GUIDANCE] == {
|
||||
K.PRODUCT_SELECTION,
|
||||
K.DESIGN_RECOMMENDATIONS,
|
||||
}
|
||||
assert depends[K.VALIDATION_RESULTS] == {K.DEPLOYMENT_GUIDANCE}
|
||||
assert depends[K.SOLUTION_GUIDE] == set(
|
||||
deliverables_in(PhaseId.SOLUTION_VALIDATION)
|
||||
)
|
||||
|
||||
|
||||
def test_submission_meeting_the_contract_has_nothing_missing():
|
||||
content = (
|
||||
"# Deployment guidance\n"
|
||||
"## 6.1. Deployment prerequisites\nEnable APIs.\n"
|
||||
"## 6.2. Step-by-step deployment instructions\nRun terraform.\n"
|
||||
)
|
||||
attachments = {"terraform/main.tf": "resource {}", "terraform/variables.tf": ""}
|
||||
|
||||
assert (
|
||||
check_submission(DeliverableKind.DEPLOYMENT_GUIDANCE, content, attachments)
|
||||
== ()
|
||||
)
|
||||
|
||||
|
||||
def test_submission_reports_missing_sections_and_attachments():
|
||||
missing = check_submission(
|
||||
DeliverableKind.DEPLOYMENT_GUIDANCE,
|
||||
"## Deployment prerequisites\n",
|
||||
{"terraform/main.tf": "resource {}"},
|
||||
)
|
||||
|
||||
assert missing == (
|
||||
"section: Step-by-step deployment instructions",
|
||||
"attachment: terraform/variables.tf",
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
"heading",
|
||||
[
|
||||
"### 5.1. Security, privacy, and compliance",
|
||||
"## security, privacy, and compliance",
|
||||
"# 5.1 Security, Privacy, and Compliance:",
|
||||
],
|
||||
)
|
||||
def test_section_matching_ignores_numbering_case_and_trailing_punctuation(heading):
|
||||
content = (
|
||||
f"{heading}\n"
|
||||
"## Reliability\n"
|
||||
"## Operational excellence\n"
|
||||
"## Cost optimization\n"
|
||||
"## Performance efficiency\n"
|
||||
"## Sustainability\n"
|
||||
)
|
||||
|
||||
assert check_submission(DeliverableKind.DESIGN_RECOMMENDATIONS, content, {}) == ()
|
||||
|
||||
|
||||
def test_section_matches_a_provider_prefixed_heading_but_not_a_longer_word():
|
||||
content = (
|
||||
"### 4.1. Google Cloud products and features mapping\n"
|
||||
"## Non-functional requirements\n"
|
||||
)
|
||||
|
||||
assert check_submission(DeliverableKind.PRODUCT_SELECTION, content, {}) == ()
|
||||
assert "section: Functional requirements" in check_submission(
|
||||
DeliverableKind.REQUIREMENTS, content, {}
|
||||
)
|
||||
|
||||
|
||||
def test_section_names_in_body_text_do_not_count_as_headings():
|
||||
missing = check_submission(
|
||||
DeliverableKind.REQUIREMENTS,
|
||||
"Functional requirements, non-functional requirements, current state and "
|
||||
"dependencies are all covered below.\n",
|
||||
{},
|
||||
)
|
||||
|
||||
assert "section: Functional requirements" in missing
|
||||
|
||||
|
||||
def test_empty_content_is_refused():
|
||||
assert check_submission(DeliverableKind.TECHNICAL_DECOMPOSITION, " \n", {}) == (
|
||||
"content: must not be empty",
|
||||
)
|
||||
Reference in New Issue
Block a user