docs: accept ADR-0004, lessons and overlays arrive as Skills
Accepted by the owner on 2026-10-08 with its six decisions as written: a person approves every lesson; a lesson must be shown to help by evaluation; lessons are per Cloud provider; overlay Skills come only from configured directories; each Execution records the Skills it loaded; and lesson candidates are client data kept out of the repository. - CONTEXT.md gains Lesson candidate, Lesson and Overlay Skill. - Iteration 4 step 9 is complete; steps 10 and 12 name the decisions they must meet and are unblocked. Neither is built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -88,6 +88,7 @@ Every step ends with the full suite passing. Steps that change agent behaviour (
|
||||
- Retire: at each vendor sync, remove lessons the upstream Skill now covers.
|
||||
- **Where:** `skills/<lessons-skill>/`, `agents/lesson-curator.md`, a curator entry point beside `eval/solution_eval.py`, `providers/gcp.yaml`, `scripts/sync-vendored-skills.sh`.
|
||||
- **Acceptance criteria:** Vendored Skills stay byte-identical. No lesson reaches a Skill without an approved issue file. Each Execution records the lessons Skill version it loaded. One real lesson has gone through the whole loop with its evaluation comparison recorded.
|
||||
- **From ADR-0004 (accepted 2026-10-08):** the lessons Skill is per Cloud provider and listed in that provider's bundle; a lesson is kept only if the evaluation with and without it holds quality and lowers Revisions, time or tokens; a lesson carries no client detail, and lesson candidates stay out of the repository.
|
||||
|
||||
## Step 11: IaC patterns Skill
|
||||
|
||||
@@ -104,6 +105,7 @@ Every step ends with the full suite passing. Steps that change agent behaviour (
|
||||
- **Rationale:** Skills are fixed at start-up: `AdkAgentRuntime` loads every Skill once, and `role_skills` is static per provider. Only 2 of the 9 Skills are our own, and both describe tools.
|
||||
- **Where:** `app/adk/adk_runtime.py`, `app/adk/roles.py`, `app/providers.py`, `ExecutionEngine.start` in `app/agent.py`, `app/a2a_server.py`, a standards Skill under `skills/`.
|
||||
- **Acceptance criteria:** An Execution can name overlay Skills at start; each passes the same Agent Skills validation as bundled Skills, and an unknown or invalid one refuses the start. An organisation standards Skill (naming, tagging, approved products) is loaded by the roles the bundle lists.
|
||||
- **From ADR-0004 (accepted 2026-10-08):** overlay Skills come only from directories the deployment configures; a caller names one by its Skill name and cannot upload one; the Execution records each overlay it loaded with a content hash. Skills are resolved per Execution, not once at start-up.
|
||||
|
||||
## Step 13: Trim Specialist context
|
||||
|
||||
|
||||
Reference in New Issue
Block a user