Some checks failed
validation / verify (push) Failing after 10s
Every Execution now begins by agreeing the scope, before requirements. - A new Phase and Deliverable, produced by a scope analyst with two tools: scope_read shows what is settled and what is not; scope_set records fields with where each value came from (the request, the customer's answer, or an assumption with its reason). Code checks each value against the catalogue. - With someone present the analyst asks for what is missing; with nobody present it assumes it, visibly. With no spec it drafts one from the request. A value the customer stated in the file is changed only by their own answer. - A submission cannot leave an essential field unknown. Code writes the completed spec, the data every later Specialist reads, and the information register, from what was recorded. - The spec's status follows the Execution: under review, approved, then locked as a Baseline. A Change request starts from the delivered scope. - The requirements analyst derives from the agreed scope and no longer asks for what it settles. About 80 tests assumed requirements came first; tests/scoped.py runs scoping ahead of a test's own script, and tests about order and counts are updated. Not run with real models. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
95 lines
3.2 KiB
Python
95 lines
3.2 KiB
Python
"""Building the engine from settings and the provider bundle."""
|
|
|
|
from typing import Any
|
|
|
|
from app.adk.fake_runtime import Call, FakeAgentRuntime
|
|
from app.agent import open_assembly
|
|
from app.config import Settings
|
|
from app.recorder import InMemoryRecorder
|
|
|
|
|
|
def settings(tmp_path, **overrides) -> Settings:
|
|
values: dict[str, Any] = {
|
|
"CHECKPOINTER": "memory",
|
|
"MCP_ENABLED": False,
|
|
"ORCHESTRATOR": "model",
|
|
"ORCHESTRATOR_BUDGET": 9,
|
|
"SPECIALIST_BUDGET": 4,
|
|
}
|
|
values.update(overrides)
|
|
return Settings(**values)
|
|
|
|
|
|
async def test_assembly_wires_roles_budgets_and_tools_from_settings(tmp_path):
|
|
runtime = FakeAgentRuntime(
|
|
{"orchestrator": [[Call("ask_user", {"questions": ["Which region?"]})]]}
|
|
)
|
|
|
|
async with open_assembly(
|
|
settings(tmp_path),
|
|
runtime=runtime,
|
|
recorder=InMemoryRecorder(),
|
|
output_root=tmp_path,
|
|
) as assembly:
|
|
interaction = await assembly.engine.start("Design ingestion")
|
|
|
|
assert interaction.prompt["questions"][0]["question"] == "Which region?"
|
|
assert assembly.bundle.name == "gcp"
|
|
assert assembly.roles["orchestrator"].budget == 9
|
|
# A role with no budget of its own takes the setting; the validator has one.
|
|
assert assembly.roles["decomposer"].budget == 4
|
|
assert assembly.roles["validator"].budget == 30
|
|
assert assembly.mcp_gaps == {}
|
|
|
|
|
|
async def test_preview_mcp_servers_follow_the_setting(tmp_path):
|
|
async with open_assembly(
|
|
settings(tmp_path, MCP_ENABLE_PREVIEW=False),
|
|
runtime=FakeAgentRuntime({}),
|
|
recorder=InMemoryRecorder(),
|
|
output_root=tmp_path,
|
|
) as assembly:
|
|
servers = assembly.roles["requirements-analyst"].mcp_servers
|
|
|
|
assert "asset_inventory" not in servers
|
|
assert "compute" in servers
|
|
|
|
|
|
async def test_the_assembly_routes_by_default_and_runs_without_a_jev_key(tmp_path):
|
|
"""With no Jev key the router follows its playbook on rules alone."""
|
|
from app.adk.fake_runtime import Call
|
|
from app.adk.runtime import NoDecider
|
|
|
|
runtime = FakeAgentRuntime(
|
|
{"scope-analyst": [[Call("needs_input", {"questions": ["Which region?"]})]]}
|
|
)
|
|
|
|
async with open_assembly(
|
|
settings(tmp_path, ORCHESTRATOR="router", TYPESAFE_API_KEY=None),
|
|
runtime=runtime,
|
|
recorder=InMemoryRecorder(),
|
|
output_root=tmp_path,
|
|
) as assembly:
|
|
interaction = await assembly.engine.start("Design ingestion")
|
|
|
|
assert isinstance(assembly.decider, NoDecider)
|
|
# The router delegated the scope with no Orchestrator model, and the scope
|
|
# analyst's question reached the user.
|
|
assert [run.role for run in runtime.runs] == ["scope-analyst"]
|
|
assert "scope_set" in runtime.runs[0].tools
|
|
assert interaction.status == "awaiting_user"
|
|
assert "reply-writer" in assembly.roles
|
|
|
|
|
|
async def test_an_unknown_orchestrator_setting_is_refused(tmp_path):
|
|
import pytest
|
|
|
|
with pytest.raises(ValueError, match="ORCHESTRATOR must be router or model"):
|
|
async with open_assembly(
|
|
settings(tmp_path, ORCHESTRATOR="llm"),
|
|
runtime=FakeAgentRuntime({}),
|
|
recorder=InMemoryRecorder(),
|
|
output_root=tmp_path,
|
|
):
|
|
pass
|