Files
gcp_solution_architecture_a…/.agents/plans/iter-06-target-architecture-graph/steps/step-11.md
Jonathan Boniface 4c4d44ef87 fix: show the Orchestrator a validation only while it stands
After deployment guidance was reopened, the Orchestrator's context still
carried the previous validation's verdicts, so it reopened the code for the
same Check three times without a validation in between (evaluation run of
2026-10-07, case 01). Record that run in the iteration 6 plan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 15:08:09 +01:00

4.4 KiB
Raw Blame History

Step 11 — Implementation Detail

Partly done. The checks are built; the evaluation run that this step exists for has not been made.

Built in eval/scoring.py:

  • requirements_chain_complete: the delivered data files form a chain with no gap.
  • every_check_passes: validation ended with no Check failed or not verifiable, and the dry-run not failed.
  • diagram_matches_graph: the delivered diagram is exactly the rendering of the delivered graph.

These replaced components_trace_to_requirements and no_blocking_findings from iteration 4 step 8.

Outstanding, and why:

  • No evaluation run. The owner stopped the last run on 2026-10-06 and asked that no further cases start until they advise. Nothing in this iteration has run against a real model.
  • The acceptance criteria are therefore unmet: all cases scoring at least 0.8, the failing-Check set never growing between passes, and at most one Revision of the deployment guidance in two of three cases.
  • Not built: the per-case record of validation passes and the Check ids failing at each. The evaluation reads only the final verdicts today.
  • Thresholds from iteration 4 step 8 are still unset.

Do not mark this step complete until a run meets the criteria. (legacy-baseline was removed on 2026-10-07 on the owner's instruction, ahead of this.)

Evaluation run of 2026-10-07, case 01 (commit e924682)

Report: eval/results/20261007T125917Z/report.json. Result: completed_with_warnings, score 73% (8 of 11 checks), 3,627 seconds, 4.25 million tokens, 144 model requests. No solution guide was written.

Stopped run, 2026-10-06 This run
First pass to a validation about 17 minutes 25 minutes
Validation passes 3 2
Failing items per pass 4, then 7, then 5 findings 0 failed Checks and 7 proposed additions, then 1 failed Check, 1 not verifiable and 1 proposed addition
Revisions deployment guidance × 3 Target architecture × 1, deployment guidance × 3
Outcome stopped at 35 minutes ended with warnings at 60 minutes

What held:

  • Every chain link was accepted on a first attempt except the Target architecture, which was refused once per attempt (7 requirements with no Check; then 4 Elements with no Check) and fixed inside its own run.
  • requirements_chain_complete and diagram_matches_graph passed.
  • The Terraform met every Check on its first attempt (0 failed of the first graph's Checks).
  • The Orchestrator followed the new routing: additions reopened the Target architecture; a failed Check reopened the code.
  • After one revision of the graph the validator proposed 1 addition, down from 7.

What failed, in order of cause:

  1. A bug in this iteration (fixed after the run, with a test). Once the deployment guidance was reopened, the Orchestrator's context still carried the old validation's verdicts. It reopened the code for K-30 three times in a row without a validation in between, reaching the Revision limit. _orchestrator_context now shows a validation only while the validation results stand as submitted.
  2. A Check that cannot be implemented had nowhere to go. K-30 required startup_cpu_boost on a Cloud Run job. Terraform rejects that argument there, so the IaC author could not satisfy it, and the validator marked it failed, which sends it back to the code. The fault was in the graph. The IaC author used 57 requests and 2.35 million tokens, 55% of the run.
  3. The target architect put a recommendation on an Element it does not apply to. K-30 came from DR-19, proposed by the validator in pass 1 for two services and applied to the job as well.
  4. Model timeouts. The target architect's model request timed out at 180 seconds in both attempts; each cost about 3 minutes.

Not yet exercised: the second pass also had a Check marked not verifiable (K-55) and a proposed addition (NFR-15). The failed-Check route took precedence, as instructed, so the gap route was not taken a second time.

Acceptance criteria: not met. The case did not complete or reach 0.8.

Changes this points to, not yet made:

  • Let the IaC author report a Check it cannot implement, with the tool's error as evidence, so that it is routed to the Target architecture and not retried as code.
  • Have the validator distinguish "the code does not do this" from "this cannot be done to this resource".
  • Check a proposed addition against the Element it names before it becomes a Check.
  • Raise or tune the model timeout for the target architect.