Files
gcp_solution_architecture_a…/.agents/plans/iter-03-kab-layout/steps/step-6.md
Jonathan Boniface 7ee49ab352
Some checks failed
validation / verify (push) Failing after 10s
latest refactoring
2026-10-06 20:22:37 +01:00

2.5 KiB

Step 6 — Implementation Detail

  1. Legacy grouped in three folders. The five legacy tests moved to tests/legacy/ and the offline harness (metrics.py, optimizer.py, eval_harness.py, test_eval_harness.py) to eval/legacy/. Run it with python -m eval.legacy.eval_harness. eval/datasets/benchmark_cases.json stayed where EVAL_DATASET_PATH points.
  2. Lint and types on live code only. ruff.toml and mypy.ini excluded app/legacy, eval/legacy and tests/legacy (exclusions removed again in step 7). ruff check . and mypy . are now clean, down from 198 and 38 findings.
  3. Live findings fixed, none suppressed by config:
    • app/database.py: modern annotations, an unused import removed, and each broad except marked with its reason (connection failure falls back to SQLite; persistence is best-effort and logged).
    • app/workflows/execution_graph.py: every node is cast for add_node, since the nodes are now typed callables.
    • scripts/list-mcp-tools.py, scripts/validate_artifacts.py, tests/test_assembly.py, tests/test_package.py, tests/agents/test_adk_engine.py, tests/agents/test_adk_runtime.py: small typing and lint fixes.
    • requirements-dev.txt: added types-protobuf and types-psycopg2.
  4. Settings. app/config.py and .env.example list live settings first and the legacy-only ones under a marked block. No setting was removed or renamed.
  5. workflow.yaml names the four Phases and their Deliverables. tests/test_workflow_manifest.py fails if it drifts from app/workflows/deliverables.py.
  6. Image. Dockerfile copies app/, agents/, providers/, skills/ and workflow.yaml only, and creates deliverables/. A new .dockerignore keeps app/legacy, .venv, .git, caches, databases and past results out of the build context.

Verified: 227 passed; ruff and mypy clean; the rebuilt image contains no app/legacy, eval/, docs/ or terraform/, and /health answers.

Still open from iteration 2's cleanup list:

  • Writes to shared paths. The engine writes only under deliverables/executions/<execution_id>/. The legacy pipeline still writes deliverables/{as-is,target,validation,guides}/ and docs/*.md, and tests/legacy/ runs it, so a test run can modify tracked files. Step 7 deleted the legacy folders, which closed this item.
  • CI. .github/workflows/ci.yml pins ruff==0.6.9 and mypy==1.11.2 and installs no project dependencies; the local tools are newer (ruff 0.16.7). CI was not run for this step.