2.5 KiB
2.5 KiB
Step 6 — Implementation Detail
- Legacy grouped in three folders. The five legacy tests moved to
tests/legacy/and the offline harness (metrics.py,optimizer.py,eval_harness.py,test_eval_harness.py) toeval/legacy/. Run it withpython -m eval.legacy.eval_harness.eval/datasets/benchmark_cases.jsonstayed whereEVAL_DATASET_PATHpoints. - Lint and types on live code only.
ruff.tomlandmypy.iniexcludedapp/legacy,eval/legacyandtests/legacy(exclusions removed again in step 7).ruff check .andmypy .are now clean, down from 198 and 38 findings. - Live findings fixed, none suppressed by config:
app/database.py: modern annotations, an unused import removed, and each broadexceptmarked with its reason (connection failure falls back to SQLite; persistence is best-effort and logged).app/workflows/execution_graph.py: every node is cast foradd_node, since the nodes are now typed callables.scripts/list-mcp-tools.py,scripts/validate_artifacts.py,tests/test_assembly.py,tests/test_package.py,tests/agents/test_adk_engine.py,tests/agents/test_adk_runtime.py: small typing and lint fixes.requirements-dev.txt: addedtypes-protobufandtypes-psycopg2.
- Settings.
app/config.pyand.env.examplelist live settings first and the legacy-only ones under a marked block. No setting was removed or renamed. workflow.yamlnames the four Phases and their Deliverables.tests/test_workflow_manifest.pyfails if it drifts fromapp/workflows/deliverables.py.- Image.
Dockerfilecopiesapp/,agents/,providers/,skills/andworkflow.yamlonly, and createsdeliverables/. A new.dockerignorekeepsapp/legacy,.venv,.git, caches, databases and past results out of the build context.
Verified: 227 passed; ruff and mypy clean; the rebuilt image contains no app/legacy, eval/, docs/ or terraform/, and /health answers.
Still open from iteration 2's cleanup list:
- Writes to shared paths. The engine writes only under
deliverables/executions/<execution_id>/. The legacy pipeline still writesdeliverables/{as-is,target,validation,guides}/anddocs/*.md, andtests/legacy/runs it, so a test run can modify tracked files. Step 7 deleted the legacy folders, which closed this item. - CI.
.github/workflows/ci.ymlpinsruff==0.6.9andmypy==1.11.2and installs no project dependencies; the local tools are newer (ruff 0.16.7). CI was not run for this step.