Files
gcp_solution_architecture_a…/.agents/plans/iter-03-kab-layout/steps/step-7.md
Jonathan Boniface 7ee49ab352
Some checks failed
validation / verify (push) Failing after 10s
latest refactoring
2026-10-06 20:22:37 +01:00

2.0 KiB

Step 7 — Implementation Detail

Decision: the original pipeline is deleted. The owner asked for its removal on 2026-10-06, after it had first been kept frozen in app/legacy/, tests/legacy/ and eval/legacy/ (step 6).

  1. Deleted app/legacy/, tests/legacy/, eval/legacy/ and eval/datasets/benchmark_cases.json.
  2. Removed the legacy-only settings from app/config.py and .env.example: HOST, PORT, the OpenAI and Azure keys, LLM_TEMPERATURE, GOOGLE_APPLICATION_CREDENTIALS, GCP_PROJECT_ID, GCP_REGION, ADK_*, DEVELOPER_KNOWLEDGE_MCP_*, SKILLS_DIR, EVAL_DATASET_PATH. Google client libraries still read GOOGLE_APPLICATION_CREDENTIALS from the environment themselves.
  3. Removed the legacy exclusions from ruff.toml, mypy.ini and .dockerignore.
  4. Removed four dependencies no live module imports: langchain, langchain-openai, sqlalchemy, asyncpg.
  5. Rewrote the top of README.md around the Orchestrator, Specialists, Skills and A2A, and pointed VALIDATION.md at eval.solution_eval.

Verified: 206 passed (227 less the 21 legacy tests); ruff check . and mypy . clean; grep -rn "app\.legacy\|eval\.legacy" app eval tests scripts is empty; the image rebuilt from the trimmed requirements.txt imports every live module, including both checkpointers, and answers /health and the agent card.

Recovering the old code: the committed versions are in git history at their pre-move paths (app/adk/, app/nodes/, app/workflows/, app/skills/, app/states/, app/agent.py, app/card.py) up to commit e94b249. Uncommitted formatting changes to those files were not kept.

Left in place, because they are checked-in sample artefacts and not pipeline code: scripts/validate_artifacts.py, tests/test_artifacts.py, tests/test_package.py, the root terraform/, docs/*.md, deliverables/{as-is,target,validation,guides}/, requirements.yaml. app/database.py keeps two methods only the old pipeline called (get_session, save_evaluation).