Files
gcp_solution_architecture_a…/.agents/plans/iter-06-target-architecture-graph/steps/step-9.md
Jonathan Boniface e9246828b3 feat: establish the Target architecture as a graph before code
Design is now approved before any infrastructure code is written (ADR-0005).
A new target-architect Specialist produces one graph of Elements,
Relationships and Checks; the diagram is rendered from it, deployment
guidance must account for every Check, and validation gives a verdict per
Check. Requirements, components, products and recommendations carry ids in
data files, and a submission with a gap in the Requirements chain is refused.

Also in this commit:
- Customer cases group Executions, with an intent history per case
- lesson candidates are captured when an Execution ends
- evaluation gains chain, verdict, judged and interactive checks, and
  per-case thresholds
- Terraform providers are cached between checks
- the requirements analyst proposes defaults instead of asking
- the legacy-baseline case and the checks that only read it are removed
- ADR-0006 (Change requests) accepted; ADR-0004 and ADR-0007 proposed
- plans for iterations 4 to 7 under .agents/plans/

Unproven with a real model: no evaluation run has completed on this design.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 13:59:09 +01:00

1.2 KiB

Step 9 — Implementation Detail

  1. The validation results require verdicts.json in place of findings.json: a dry_run result, one verdict per Check (pass, fail or not_verifiable) with evidence, and a separate list of proposed_additions.
  2. Refused: a Check with no verdict, a Check with two, a verdict on something that is not a Check, a verdict without evidence, a missing dry-run result.
  3. A proposed addition is never a failure. This is the rule that stops validation findings growing between passes: the validator cannot add to what the code is judged against.
  4. validation_outcome in app/workflows/chain.py separates faults in the code (failed Checks) from gaps in the graph (not verifiable, proposed additions). Lesson candidates and the evaluation use it.

Changed from the plan: the dry-run is its own dry_run entry, not a Check in the graph, so the Target architecture stays free of tooling concerns.

check_findings and FINDINGS_ATTACHMENT from iteration 4 step 1 are gone. Lesson candidate types are now failed_check, unverifiable_check and proposed_addition.

Tests: tests/execution/test_requirements_chain.py, "code and validation answer the graph"; tests/execution/test_lessons.py.