Files
gcp_solution_architecture_a…/.agents/plans/iter-04-learning-and-skills/steps/step-5.md
Jonathan Boniface e9246828b3 feat: establish the Target architecture as a graph before code
Design is now approved before any infrastructure code is written (ADR-0005).
A new target-architect Specialist produces one graph of Elements,
Relationships and Checks; the diagram is rendered from it, deployment
guidance must account for every Check, and validation gives a verdict per
Check. Requirements, components, products and recommendations carry ids in
data files, and a submission with a gap in the Requirements chain is refused.

Also in this commit:
- Customer cases group Executions, with an intent history per case
- lesson candidates are captured when an Execution ends
- evaluation gains chain, verdict, judged and interactive checks, and
  per-case thresholds
- Terraform providers are cached between checks
- the requirements analyst proposes defaults instead of asking
- the legacy-baseline case and the checks that only read it are removed
- ADR-0006 (Change requests) accepted; ADR-0004 and ADR-0007 proposed
- plans for iterations 4 to 7 under .agents/plans/

Unproven with a real model: no evaluation run has completed on this design.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 13:59:09 +01:00

1.0 KiB

Step 5 — Implementation Detail

  1. RunLimiter in app/adk/runtime.py caps agent runs in flight. slot() holds one; lend() gives the caller's slot up while its own fan-out runs.
  2. specialist_task takes a slot for each Specialist run. The pillar tool lends the design advisor's slot and takes one per advisor, so the fan-out shares the cap and a cap of 1 cannot deadlock.
  3. Setting MAX_PARALLEL_SPECIALISTS (default 4, as the spec's Risks section asked). open_assembly builds one limiter and gives it to both the engine and the tool factory.

Changed from the plan: the cap is per engine process, not per Execution. Model rate limits apply to the project, so one cap across concurrent Executions is the stricter and more useful bound.

An ExecutionEngine built without a limiter is uncapped, which keeps direct construction in tests unchanged.

Tests: cap of 1 gives a peak of 1 and no cap gives a peak of 2 (tests/execution/test_engine.py); the fan-out under a held slot with a cap of 1 completes with a peak of 1 (tests/execution/test_pillars.py).