Files
gcp_solution_architecture_a…/.agents/plans/iter-04-learning-and-skills/steps/step-1.md
Jonathan Boniface e9246828b3 feat: establish the Target architecture as a graph before code
Design is now approved before any infrastructure code is written (ADR-0005).
A new target-architect Specialist produces one graph of Elements,
Relationships and Checks; the diagram is rendered from it, deployment
guidance must account for every Check, and validation gives a verdict per
Check. Requirements, components, products and recommendations carry ids in
data files, and a submission with a gap in the Requirements chain is refused.

Also in this commit:
- Customer cases group Executions, with an intent history per case
- lesson candidates are captured when an Execution ends
- evaluation gains chain, verdict, judged and interactive checks, and
  per-case thresholds
- Terraform providers are cached between checks
- the requirements analyst proposes defaults instead of asking
- the legacy-baseline case and the checks that only read it are removed
- ADR-0006 (Change requests) accepted; ADR-0004 and ADR-0007 proposed
- plans for iterations 4 to 7 under .agents/plans/

Unproven with a real model: no evaluation run has completed on this design.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-07 13:59:09 +01:00

1.2 KiB

Step 1 — Implementation Detail

  1. validation_results now requires a findings.json attachment (FINDINGS_ATTACHMENT in app/workflows/deliverables.py).
  2. check_findings validates it at submission: a JSON list of objects with deliverable (a Deliverable kind), severity (critical, high, medium, low), evidence and rule. [] is valid and means a pass. Each problem is refused by field, for example findings.json[1].severity: must be one of ....
  3. agents/validator.md tells the validator to attach it; the format and an example live in skills/iac-validation/SKILL.md under "Reporting findings".
  4. The file is written with the other attachments to deliverables/executions/<id>/findings.json.

The check was added to check_submission, not to app/tools/execution.py as planned, so every contract rule stays in one function.

Tests: tests/execution/test_deliverables.py (missing attachment, empty list, well-formed finding, malformed JSON, per-field problems).

Not verified: no real-model run has confirmed the validator produces a well-formed file on its first submission. A malformed one costs a retry inside the validator's run, not a Revision.