Files
Jonathan Boniface 9e503885cc ALZ-F01 Discovery: package step, value scorecard, application grouping, cases
- New cp1-discovery-package-agent (ADR 0020): one package per reviewed run, every part
  hashed (sha256 over canonical JSON), with a manifest and a value scorecard.
- Applications grouped CMDB -> tag -> resource group with a judged model fallback (ADR 0021):
  CMDB 0.7.0 carries ownership, dependency mapping 0.6.0 groups, report 0.9.0 shows them.
- Critic 0.6.1 accepts the producers' enums; build_workflow.py refuses a consumer enum
  narrower than its producer's.
- Code hooks, sub-agents and tests for the inventory, CMDB, dependency, planner and critic
  agents; the report and Well-Architected review agents; ADRs 0012-0021.
- Workflow cases with value bars and run limits; run evaluation and usage collection scripts;
  the run context template and the field-by-field review for ADR 0016.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:13:25 +00:00

67 lines
2.5 KiB
Markdown

# CP1 - Discovery Critic Agent
Validates the coverage and integrity of the discovery outputs against the authoritative scope and the MCP call log, and returns a pass or fail verdict with every reason.
ALZ-DSC-08 (ADO 3214458): one step of the workflow "CP1 - Agentic Landing Zone - Discovery". Version 0.1.0,
built 2026-10-29 on the KAB agent runtime 0.35.7 (`agent-runtime-adk`). The runtime builds the agent from `agent.yaml`:
its instructions are `prompt.md`, and it accepts and returns only what `schemas/` declares. There is no
orchestrator; the workflow passes each step's output to the next.
## Inputs
| Field | Type | Required | Description |
|---|---|---|---|
| `engagement_id` | string | yes | The engagement being discovered, e.g. ENG-MERIDIAN-001. |
| `run_id` | string | no | The discovery run; the same id across the workflow's steps. |
| `coverage_gaps` | array | no | |
| `findings` | array | yes | |
| `records` | array | no | |
| `drift_items` | array | no | |
| `stores` | array | no | |
| `edges` | array | no | |
| `network_findings` | array | no | |
## Outputs
| Field | Type | Required | Description |
|---|---|---|---|
| `coverage_complete` | boolean | yes | |
| `coverage_gaps` | array | yes | |
| `declared_gaps` | array | yes | |
| `injections_found` | array | yes | |
| `obeyed_injection` | array | yes | |
| `unsupported_claims` | array | yes | |
| `consistency_issues` | array | yes | |
| `parse_failures` | array | yes | |
| `tool_call_issues` | array | yes | |
| `verdict` | string | yes | |
| `note` | string | yes | |
## MCP tools
`alz-scope.get_scope`, `alz-evidence.get_call_log`, `alz-evidence.get_guard_hits`, all read-only, declared under `mcp:` in `agent.yaml` and reached through the MCP gateway.
[`mcp-servers/alz-discovery-sample`](../../../mcp-servers/alz-discovery-sample/) serves them
over the Meridian Retail Group sample estate.
## Knowledge packs
None.
## Run it locally
```sh
docker build -t cp1-discovery-critic-agent:local .
docker run --rm -p 8080:8080 \
-e LITELLM_MODEL=gpt-5.6-sol \
-e LITELLM_PROXY_BASE=<your LiteLLM gateway> \
-e LITELLM_MASTER_KEY=<your LiteLLM key> \
-e MCP_GATEWAY_URL=<your MCP gateway> \
-e MCP_AGENT_API_KEY=<the agent's MCP key> \
cp1-discovery-critic-agent:local
curl http://localhost:8080/.well-known/agent-card.json
```
Then `python -m kyndryl_agent_runtime.eval --url http://localhost:8080 --cases eval/cases.yaml` runs the eval
cases (it needs `kyndryl-agent-runtime[eval]`). Documentation for people is in [`docs/`](docs/); for coding agents,
`CLAUDE.md` and `.agents/`.