Some checks failed
check agents / check (push) Failing after 14s
- Critic 0.3.0: the hooks look up every disposition citation in the verified Discovery package (app/evidence.py). An unresolved citation fails K-02 and rejects the disposition; whether the records support the basis stays the model's judgement. - Critic 0.3.1: K-02 judges a disposition's citations together (evidence_ref is the primary record), ADR 0013 addendum. - Profiler 0.1.1: represents edges are not dependencies (ADR 0012, now covering ALZ-ASM-02). - Scaffold: builds every prompt before deleting anything. - Tests on Discovery run exec_58ba6a71d00b's package and runs 007 and 009 (15). - Run exec_49e355141382 (RUN-ASM-AZURE-012) passed on crucible-kab-dev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
38 lines
2.3 KiB
Markdown
38 lines
2.3 KiB
Markdown
# 0012. A `represents` edge is not a dependency
|
|
|
|
| | |
|
|
|---|---|
|
|
| Status | Accepted |
|
|
| Date | 2026-11-05 |
|
|
| Decided by | Product owner, 2026-11-05: "lets solve these first" (the run's faults are fixed before it is repeated); the rule follows Discovery's F01 ADR 0019 |
|
|
| Requirements changed | ALZ-ASM-02, ALZ-ASM-03 and ALZ-ASM-04: the Application Dependents rule leaves out `represents` edges. ALZ-ASM-04 and ALZ-ASM-06 use ALZ-ASM-03's rule |
|
|
|
|
## Context
|
|
|
|
- The Application Dependents rule (ALZ-ASM-03) lifts every ALZ-DSC-06 edge to applications.
|
|
- Since F01 ADR 0019, Discovery also writes a `represents` edge for each CMDB record it matched to an inventory asset
|
|
(CMDB CI → resource). It records that the two are the same asset; it isn't a dependency.
|
|
- In run `exec_2cd7a953335b`, the eight `represents` edges of APP-001 (E-008 to E-015) were counted as eight dependents:
|
|
- the risk scorer set fan-in to 1.0, the only factor available, so the score was 1.00 and APP-001 was high-risk;
|
|
- the disposition agent ruled out retire for eight dependents.
|
|
The critic model rejected the disposition under K-02 for citing them. Its other edges (E-001, E-002, E-005, E-007)
|
|
run from APP-001's own assets outwards: they are dependencies, not dependents.
|
|
- ALZ-ASM-04's prompt had no rule of its own for lifting dependents.
|
|
|
|
## Decision
|
|
|
|
1. **`dependency(e) = e.type != 'represents'`** in ALZ-ASM-03's Application Dependents rule: a `represents` edge is
|
|
left out of both an application's dependents and its dependencies.
|
|
2. **ALZ-ASM-04 and ALZ-ASM-06 carry ALZ-ASM-03's rule,** copied into their prompts by the scaffold, so all three lift
|
|
dependents the same way.
|
|
3. **ALZ-ASM-02 leaves them out too** (added 2026-11-06). The profiler has its own copy of the rule, for the
|
|
profile's `dependents`, `depends_on` and `dependency_exposure`, and was missed at first: in run `exec_d170329cba65`
|
|
it listed APP-001's eight `represents` edges as downstream dependents, and the critic failed K-03.
|
|
|
|
## Consequences
|
|
|
|
- **APP-001 has no dependents** in the current Discovery package: fan-in 0.0, so its risk score falls from 1.00 to
|
|
0.00 on the one factor available, and it leaves the high-risk tail. Retire is still ruled out by its assets'
|
|
`retire_constraint`.
|
|
- **A future Discovery edge type** that isn't a dependency needs the same treatment here.
|