Files
cp1-agents/individual-agents/ALZ-F01: Discovery Workflow Agent/docs/adr/0013.md
Jonathan Boniface 9e503885cc ALZ-F01 Discovery: package step, value scorecard, application grouping, cases
- New cp1-discovery-package-agent (ADR 0020): one package per reviewed run, every part
  hashed (sha256 over canonical JSON), with a manifest and a value scorecard.
- Applications grouped CMDB -> tag -> resource group with a judged model fallback (ADR 0021):
  CMDB 0.7.0 carries ownership, dependency mapping 0.6.0 groups, report 0.9.0 shows them.
- Critic 0.6.1 accepts the producers' enums; build_workflow.py refuses a consumer enum
  narrower than its producer's.
- Code hooks, sub-agents and tests for the inventory, CMDB, dependency, planner and critic
  agents; the report and Well-Architected review agents; ADRs 0012-0021.
- Workflow cases with value bars and run limits; run evaluation and usage collection scripts;
  the run context template and the field-by-field review for ADR 0016.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 22:13:25 +00:00

42 lines
2.5 KiB
Markdown

# 0013. A `provider` input lets one workflow read the sample estate or a live cloud
| | |
|---|---|
| Status | Accepted |
| Date | 2026-11-03 |
| Decided by | Product owner, 2026-11-03: adapt both patterns, with a workflow value choosing the hyperscaler; GCP first |
| Requirements changed | DSC-01 to DSC-09: the scope, scan, classification, network and critic sources in a live run |
## Context
The Vault Service is running on kab-dev, and the CP1 tenant's Default Project holds connections for
`azure-discovery` and `gcp-discovery`. The agents called only the sample server.
The runtime offers every declared MCP tool to the model, and its `before_model` hook can only add instructions, so
a code-only choice of cloud isn't possible in a declarative agent (see the repository's
`docs/hyperscaler-interchange-review-note-2026-11-01.md`). The cloud servers stay standalone.
## Decision
- **A `provider` run input**, `sample`, `azure` or `gcp` (default `sample`), goes to every step. The runtime
enforces the enum. With `sample`, nothing changes.
- **Live tools.** The planner, scan, classification, network and critic agents also declare the live tools they
need from `azure-discovery` and `gcp-discovery`. A "Live provider" section in each prompt confines a live run to
`{provider}_*` tools. Inventory, CMDB, dependency and report agents call no live tool.
- **Live scope.** Scope comes from the cloud's own listings: servers, workloads, clusters and data stores, every
kind, every page. Each resource's own name or id is its scope entry id, and its region is its site.
- **Missing sources.** CMDB, ITSM, flows and schemas are declared `source_gaps` (`no_connection`).
- **Wrong cloud.** The critic fails a run in which any identifier belongs to the other cloud.
- **AWS later.** Its tools take `account_id` and `region`, and no AWS connection is stored yet.
## Consequences
- **Choosing the cloud rests on the prompt.** Both connections are in one project, so a wrong-cloud call would
succeed. The critic's identifier check is the backstop.
- **Large estates.** A live estate's tool output goes straight into each model's context. The GCP trial project
is about 40 KB; the Azure subscription was about 5.3 MB (most of it Advisor recommendations, which no agent
calls), and needs testing before it's relied on.
- **No call-log check.** The critic can't check tool calls in a live run (`call_log` and `guard_hits` go in
`not_checked`).
- **Every declared server must be registered and healthy** for the agents to start, the cloud servers included.