Files
gcp_solution_architecture_a…/.agents/plans/iter-06-target-architecture-graph/MAP.md
Jonathan Boniface ee1ba38867 feat: a design-time coverage review, measured and left off
A reviewer role reads the requirements and recommendations against the Checks
when the Target architecture is first submitted. Three runs of case 03: it did
not stop the validator sending the design back, and the designs it reviewed
ended with 87 and 93 Checks against 52, so they cost more. It stays behind
DESIGN_COVERAGE_REVIEW, off (iteration 6 step 13).

Also: the schema review no longer reads `true` or `false` in backticks as a
setting name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-10 12:33:06 +01:00

92 lines
5.2 KiB
Markdown

# Plan Map
**Iteration:** 6, the Target architecture graph
**Intent:** Establish the Target architecture as one explicit graph of Elements, Relationships and Checks before any infrastructure code is written, and derive and check every later Deliverable from it, so that the outcome is understood before code exists and validation has a fixed bar.
**Status:** complete. Steps 1 to 10 built; all four cases, the interactive one included, completed twice with real models on 2026-10-08 and the thresholds are set (`steps/step-11.md`)
**This directory covers:** steps 1 to 11
## Order of work
Build this iteration before the remaining steps of iteration 4 (10 to 14) and before iteration 5. It changes Deliverables, Phases and the validation format that those steps build on. The effects on them are listed at the end of this file.
## Sources of truth
- `docs/adr/0005-the-target-architecture-is-an-explicit-graph.md`: the decision, its three points to confirm, and the rejected alternatives. Status `proposed`.
- `CONTEXT.md`: Target architecture, Element, Relationship, Check, Requirements chain. Use these words; "Dependency" stays the link between Deliverables.
- `iter-04-learning-and-skills/steps/step-8.md`, "The evaluation run of 2026-10-06": the evidence. Three validation passes gave 4, 7, then 5 different findings on the same Terraform.
- `docs/adr/0002-*.md`: the graph's format and how to write it are behaviour, so they live in a Skill; the engine only checks the result.
## The flow this iteration builds
```mermaid
flowchart TD
REQ([Workflow request]) --> R[Requirements]
R --> D[Technical decomposition]
D --> A1{{Approval: requirements discovery}}
A1 --> PS[Product selection]
PS --> DR[Design recommendations]
R --> DR
PS --> TA
DR --> TA[Target architecture: Elements, Relationships, Checks]
TA --> A2{{Approval: design}}
A2 --> DESC[Architecture description]
A2 --> IAC[Deployment guidance]
TA -.rendered by code.-> DIA[Architecture diagram]
IAC --> A3{{Approval: implementation}}
DESC --> A3
A3 --> VAL[Validation: a verdict per Check]
VAL -->|a Check fails| IAC
VAL -->|the graph is missing something| TA
VAL -->|every Check passes| A4{{Approval: validation}}
A4 --> G[Solution guide]
G --> A5{{Approval: packaging}}
```
## Status
| Step | What | Size | Status |
|---|---|---|---|
| 1 | Accept ADR-0005 | S | complete: accepted 2026-10-07 |
| 2 | Identify requirements, components and recommendations by id | M | complete |
| 3 | The graph: format, parsing and structural rules | M | complete |
| 4 | The Target architecture Deliverable, its Specialist and its Skill | M | complete; unproven with a real model |
| 5 | Completeness: the Requirements chain is a submission rule | M | complete |
| 6 | Split the solution architecture Phase: design, then implementation | M | complete |
| 7 | The diagram is rendered from the graph | S | complete |
| 8 | Deployment guidance implements the graph | M | complete |
| 9 | Validation gives a verdict per Check | M | complete |
| 10 | Revision routing: the code or the graph | S | complete; routing unproven with a real model |
| 11 | Evaluation: prove the loop converges | M | complete: all four cases pass, each run twice on 2026-10-08; thresholds set (`steps/step-11.md`) |
| 12 | Why the Target architecture is revised | S | investigated 2026-10-10: two causes, about half each; two instructions changed; the design-time coverage review it proposed is step 13 (`steps/step-12.md`) |
| 13 | A model reviews coverage at design time | M | built and measured on 2026-10-10: it did not prevent the validator's gaps and made designs larger; left off (`steps/step-13.md`) |
Size: S under a day, M a few days.
## Dependency graph
- Step 1: no dependencies
- Step 2: depends on step 1
- Step 3: depends on step 1
- Step 4: depends on step 3
- Step 5: depends on step 2, step 4
- Step 6: depends on step 4
- Step 7: depends on step 4
- Step 8: depends on step 5
- Step 9: depends on step 8
- Step 10: depends on step 6, step 9
- Step 11: depends on step 7, step 10
Steps 2 and 3 can be built side by side, as can 6 and 7.
## Effects on other iterations
- **Iteration 4 step 1** (`findings.json`): replaced by the verdicts of step 9 here. The free-form finding list goes.
- **Iteration 4 step 4** (contracts): the diagram's contract goes with the diagrammer; the decomposition's component table becomes data in step 2 here.
- **Iteration 4 step 6** (Orchestrator step order): rewritten by step 10 here.
- **Iteration 4 step 7** (lesson candidates): `finding` candidates become failed Checks and proposed additions.
- **Iteration 4 step 8** (evaluation): `no_blocking_findings` is rewritten against verdicts; the unset thresholds are set by step 11 here.
- **Iteration 4 step 11** (IaC patterns Skill): its patterns should be keyed by the product of an Element.
- **Iteration 4 step 13** (trim Specialist context): mostly achieved here, since later Specialists work from the graph. Re-scope it after step 11.
- **Iteration 5 step 5** (finding-to-Deliverable routing): no longer needed; a failed Check already names what it applies to.
- **Iteration 5 step 4** (semantic checks at submission): can judge whether each Check is verifiable as written.